From: Greg KH <gregkh@suse.de>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 2/7] debugfs: add debugfs_create_int
Date: Mon, 4 Jul 2011 08:32:24 -0700 [thread overview]
Message-ID: <20110704153224.GA17358@suse.de> (raw)
In-Reply-To: <CAC5umyh_25z9LV=T86807ey8yZRGwmhsPG44OqZdtcR-3wzb4Q@mail.gmail.com>
On Mon, Jul 04, 2011 at 02:31:25PM +0900, Akinobu Mita wrote:
> 2011/7/4 Greg KH <gregkh@suse.de>:
> > On Sun, Jul 03, 2011 at 11:16:16PM +0900, Akinobu Mita wrote:
> >> Introduce debugfs_create_int() for creating a debugfs file that is used to
> >> read and write an int value.
> >
> > Um, what's wrong with the existing s32 and s64 versions that debugfs
> > already provides?
>
> I couldn't find s32 version in linux/debugfs.h
>
> > userspace doesn't know what "int" means for the kernel as it might be
> > running in 32bit mode with a 64bit kernel. That is why this isn't a
> > good idea, so please convert your other patch to use the existing api
> > and change the variable type in your patch.
>
> Shoud I add debugfs_create_s32() instead of debugfs_create_int() for
> this?
Does it have to be a signed value? If not, just use the
debugfs_create_u32() function. Or use that and just cast the result,
right?
thanks,
greg k-h
next prev parent reply other threads:[~2011-07-04 15:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-03 14:16 [PATCH 0/7] notifier error injection Akinobu Mita
2011-07-03 14:16 ` [PATCH 1/7] pm: improve error code of pm_notifier_call_chain() Akinobu Mita
2011-07-03 17:15 ` Pavel Machek
2011-07-04 5:32 ` Akinobu Mita
2011-07-07 21:06 ` Rafael J. Wysocki
2011-07-08 15:50 ` Akinobu Mita
2011-07-08 18:59 ` Rafael J. Wysocki
2011-07-03 14:16 ` [PATCH 2/7] debugfs: add debugfs_create_int Akinobu Mita
2011-07-03 16:23 ` Greg KH
2011-07-04 5:31 ` Akinobu Mita
2011-07-04 15:32 ` Greg KH [this message]
2011-07-05 4:42 ` Akinobu Mita
2011-07-03 14:16 ` [PATCH 3/7] fault-injection: notifier error injection Akinobu Mita
2011-07-03 17:16 ` Pavel Machek
2011-07-04 5:35 ` Akinobu Mita
2011-07-03 14:16 ` [PATCH 4/7] cpu: CPU " Akinobu Mita
2011-07-03 14:16 ` [PATCH 5/7] PM: PM " Akinobu Mita
2011-07-07 21:14 ` Rafael J. Wysocki
2011-07-08 15:56 ` Akinobu Mita
2011-07-08 17:43 ` Rafael J. Wysocki
2011-07-03 14:16 ` [PATCH 6/7] memory: memory " Akinobu Mita
2011-07-03 14:16 ` [PATCH 7/7] powerpc: pSeries reconfig " Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704153224.GA17358@suse.de \
--to=gregkh@suse.de \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox