[PATCH] drivers: staging: iio: adc: fix uninitialized use

[PATCH] drivers: staging: iio: adc: fix uninitialized use

[Chris Forbes]

Fixed an uninitialized variable access. In the first two error paths in
max1363_probe(), 'st' is not yet initialized, but its 'reg' member is
accessed anyway. This would most likely crash.

The intended value for st->reg *is* available at that point in 'reg',
so just use that directly.

Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
---
 drivers/staging/iio/adc/max1363_core.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c
index 98cebd2..ebecf14 100644
--- a/drivers/staging/iio/adc/max1363_core.c
+++ b/drivers/staging/iio/adc/max1363_core.c
@@ -1335,11 +1335,11 @@ error_free_device:
 	else
 		iio_device_unregister(indio_dev);
 error_disable_reg:
-	if (!IS_ERR(st->reg))
-		regulator_disable(st->reg);
+	if (!IS_ERR(reg))
+		regulator_disable(reg);
 error_put_reg:
-	if (!IS_ERR(st->reg))
-		regulator_put(st->reg);
+	if (!IS_ERR(reg))
+		regulator_put(reg);
 
 	return ret;
 }
-- 
1.7.4.1

Re: [PATCH] drivers: staging: iio: adc: fix uninitialized use

[Jonathan Cameron]

On 07/03/11 02:47, Chris Forbes wrote:
> Fixed an uninitialized variable access. In the first two error paths in
> max1363_probe(), 'st' is not yet initialized, but its 'reg' member is
> accessed anyway. This would most likely crash.
Good spot. Please tech TODO files for staging patches. In this case it would
have given you the mailing list, now cc'd.
> 
> The intended value for st->reg *is* available at that point in 'reg',
> so just use that directly.
> 
> Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
>  drivers/staging/iio/adc/max1363_core.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c
> index 98cebd2..ebecf14 100644
> --- a/drivers/staging/iio/adc/max1363_core.c
> +++ b/drivers/staging/iio/adc/max1363_core.c
> @@ -1335,11 +1335,11 @@ error_free_device:
>  	else
>  		iio_device_unregister(indio_dev);
>  error_disable_reg:
> -	if (!IS_ERR(st->reg))
> -		regulator_disable(st->reg);
> +	if (!IS_ERR(reg))
> +		regulator_disable(reg);
>  error_put_reg:
> -	if (!IS_ERR(st->reg))
> -		regulator_put(st->reg);
> +	if (!IS_ERR(reg))
> +		regulator_put(reg);
>  
>  	return ret;
>  }

Re: [PATCH] drivers: staging: iio: adc: fix uninitialized use

[Dan Carpenter]

On Mon, Jul 04, 2011 at 10:01:11AM +0100, Jonathan Cameron wrote:
> On 07/03/11 02:47, Chris Forbes wrote:
> > Fixed an uninitialized variable access. In the first two error paths in
> > max1363_probe(), 'st' is not yet initialized, but its 'reg' member is
> > accessed anyway. This would most likely crash.
> Good spot. Please tech TODO files for staging patches. In this case it would
> have given you the mailing list, now cc'd.

It would better to add an entry to MAINTAINERS so that
./scripts/get_maintainer.pl gave the right lists.

regards,
dan carpenter

Re: [PATCH] drivers: staging: iio: adc: fix uninitialized use

[Jonathan Cameron]

On 07/04/11 10:10, Dan Carpenter wrote:
> On Mon, Jul 04, 2011 at 10:01:11AM +0100, Jonathan Cameron wrote:
>> On 07/03/11 02:47, Chris Forbes wrote:
>>> Fixed an uninitialized variable access. In the first two error paths in
>>> max1363_probe(), 'st' is not yet initialized, but its 'reg' member is
>>> accessed anyway. This would most likely crash.
>> Good spot. Please tech TODO files for staging patches. In this case it would
>> have given you the mailing list, now cc'd.
> 
> It would better to add an entry to MAINTAINERS so that
> ./scripts/get_maintainer.pl gave the right lists.
Perhaps, but Greg KH is anti, so it isn't going to happen.

Re: [PATCH] drivers: staging: iio: adc: fix uninitialized use

[Greg KH]

On Mon, Jul 04, 2011 at 10:45:01AM +0100, Jonathan Cameron wrote:
> On 07/04/11 10:10, Dan Carpenter wrote:
> > On Mon, Jul 04, 2011 at 10:01:11AM +0100, Jonathan Cameron wrote:
> >> On 07/03/11 02:47, Chris Forbes wrote:
> >>> Fixed an uninitialized variable access. In the first two error paths in
> >>> max1363_probe(), 'st' is not yet initialized, but its 'reg' member is
> >>> accessed anyway. This would most likely crash.
> >> Good spot. Please tech TODO files for staging patches. In this case it would
> >> have given you the mailing list, now cc'd.
> > 
> > It would better to add an entry to MAINTAINERS so that
> > ./scripts/get_maintainer.pl gave the right lists.
> Perhaps, but Greg KH is anti, so it isn't going to happen.

I'm coming around on this, for larger chunks of code, like iio, I don't
mind it, so feel free to send me an entry.

thanks,

greg k-h

[PATCH 00/14] MAINTAINERS: Add staging

[Joe Perches]

If you've changed your mind, here are the parts that apply
from the original submission in June, 2010.

Added a removal of one deleted section as well.

Joe Perches (14):
  MAINTAINERS: Add STAGING - ASUS OLED
  MAINTAINERS: Add STAGING - COMEDI
  MAINTAINERS: Add STAGING - CRYSTAL HD VIDEO DECODER
  MAINTAINERS: Add STAGING - ECHO CANCELLER
  MAINTAINERS: Add STAGING - FRONTIER TRANZPORT AND ALPHATRACK
  MAINTAINERS: Add STAGING - HYPER-V (MICROSOFT)
  MAINTAINERS: Add STAGING - INDUSTRIAL IO
  MAINTAINERS: Add STAGING - PARALLEL LCD/KEYPAD PANEL DRIVER
  MAINTAINERS: Add STAGING - SILICON MOTION SM7XX FRAME BUFFER DRIVER
  MAINTAINERS: Add STAGING - VIA VT665X DRIVERS
  MAINTAINERS: Add STAGING - WINBOND IS89C35 WLAN USB DRIVER
  MAINTAINERS: Add STAGING - AGERE HERMES II and II.5 WIRELESS DRIVERS
  MAINTAINERS: Add STAGING - XGI Z7,Z9,Z11 PCI DISPLAY DRIVER
  MAINTAINERS: Remove se401 entry

 MAINTAINERS |   79 +++++++++++++++++++++++++++++++++++++++++++++++++++++-----
 1 files changed, 72 insertions(+), 7 deletions(-)

-- 
1.7.6.131.g99019

[PATCH 01/14] MAINTAINERS: Add STAGING - ASUS OLED

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7fe708d..6f0d683 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6069,6 +6069,11 @@ L:	devel@driverdev.osuosl.org
 S:	Maintained
 F:	drivers/staging/
 
+STAGING - ASUS OLED
+M:	Jakub Schmidtke <sjakub@gmail.com>
+S:	Odd Fixes
+F:	drivers/staging/asus_oled/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 02/14] MAINTAINERS: Add STAGING - COMEDI

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6f0d683..6d8e58b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6074,6 +6074,12 @@ M:	Jakub Schmidtke <sjakub@gmail.com>
 S:	Odd Fixes
 F:	drivers/staging/asus_oled/
 
+STAGING - COMEDI
+M:	Ian Abbott <abbotti@mev.co.uk>
+M:	Mori Hess <fmhess@users.sourceforge.net>
+S:	Odd Fixes
+F:	drivers/staging/comedi/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 03/14] MAINTAINERS: Add STAGING - CRYSTAL HD VIDEO DECODER

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6d8e58b..e42923b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6080,6 +6080,14 @@ M:	Mori Hess <fmhess@users.sourceforge.net>
 S:	Odd Fixes
 F:	drivers/staging/comedi/
 
+STAGING - CRYSTAL HD VIDEO DECODER
+M:	Naren Sankar <nsankar@broadcom.com>
+M:	Jarod Wilson <jarod@wilsonet.com>
+M:	Scott Davilla <davilla@4pi.com>
+M:	Manu Abraham <abraham.manu@gmail.com>
+S:	Odd Fixes
+F:	drivers/staging/crystalhd/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 04/14] MAINTAINERS: Add STAGING - ECHO CANCELLER

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e42923b..320fd7c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6088,6 +6088,12 @@ M:	Manu Abraham <abraham.manu@gmail.com>
 S:	Odd Fixes
 F:	drivers/staging/crystalhd/
 
+STAGING - ECHO CANCELLER
+M:	Steve Underwood <steveu@coppice.org>
+M:	David Rowe <david@rowetel.com>
+S:	Odd Fixes
+F:	drivers/staging/echo/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 05/14] MAINTAINERS: Add STAGING - FRONTIER TRANZPORT AND ALPHATRACK

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 320fd7c..9c7baa9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6094,6 +6094,11 @@ M:	David Rowe <david@rowetel.com>
 S:	Odd Fixes
 F:	drivers/staging/echo/
 
+STAGING - FRONTIER TRANZPORT AND ALPHATRACK
+M:	David Täht <d@teklibre.com>
+S:	Odd Fixes
+F:	drivers/staging/frontier/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 06/14] MAINTAINERS: Add STAGING - HYPER-V (MICROSOFT)

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9c7baa9..70ccf25 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6099,6 +6099,12 @@ M:	David Täht <d@teklibre.com>
 S:	Odd Fixes
 F:	drivers/staging/frontier/
 
+STAGING - HYPER-V (MICROSOFT)
+M:	Hank Janssen <hjanssen@microsoft.com>
+M:	Haiyang Zhang <haiyangz@microsoft.com>
+S:	Odd Fixes
+F:	drivers/staging/hv/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 07/14] MAINTAINERS: Add STAGING - INDUSTRIAL IO

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 70ccf25..9968b10 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6105,6 +6105,11 @@ M:	Haiyang Zhang <haiyangz@microsoft.com>
 S:	Odd Fixes
 F:	drivers/staging/hv/
 
+STAGING - INDUSTRIAL IO
+M:	Jonathan Cameron <jic23@cam.ac.uk>
+S:	Odd Fixes
+F:	drivers/staging/iio/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 08/14] MAINTAINERS: Add STAGING - PARALLEL LCD/KEYPAD PANEL DRIVER

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9968b10..9cd7ea9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6110,6 +6110,11 @@ M:	Jonathan Cameron <jic23@cam.ac.uk>
 S:	Odd Fixes
 F:	drivers/staging/iio/
 
+STAGING -  PARALLEL LCD/KEYPAD PANEL DRIVER
+M:	Willy Tarreau <willy@meta-x.org>
+S:	Odd Fixes
+F:	drivers/staging/panel/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 09/14] MAINTAINERS: Add STAGING - SILICON MOTION SM7XX FRAME BUFFER DRIVER

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9cd7ea9..b0ce557 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6115,6 +6115,11 @@ M:	Willy Tarreau <willy@meta-x.org>
 S:	Odd Fixes
 F:	drivers/staging/panel/
 
+STAGING - SILICON MOTION SM7XX FRAME BUFFER DRIVER
+M:	Teddy Wang <teddy.wang@siliconmotion.com.cn>
+S:	Odd Fixes
+F:	drivers/staging/sm7xx/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 10/14] MAINTAINERS: Add STAGING - VIA VT665X DRIVERS

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index b0ce557..ac25e66 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6120,6 +6120,11 @@ M:	Teddy Wang <teddy.wang@siliconmotion.com.cn>
 S:	Odd Fixes
 F:	drivers/staging/sm7xx/
 
+STAGING - VIA VT665X DRIVERS
+M:	Forest Bond <forest@alittletooquiet.net>
+S:	Odd Fixes
+F:	drivers/staging/vt665?/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 11/14] MAINTAINERS: Add STAGING - WINBOND IS89C35 WLAN USB DRIVER

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index ac25e66..cfb22e2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6125,6 +6125,11 @@ M:	Forest Bond <forest@alittletooquiet.net>
 S:	Odd Fixes
 F:	drivers/staging/vt665?/
 
+STAGING - WINBOND IS89C35 WLAN USB DRIVER
+M:	Pavel Machek <pavel@ucw.cz>
+S:	Odd Fixes
+F:	drivers/staging/winbond/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 12/14] MAINTAINERS: Add STAGING - AGERE HERMES II and II.5 WIRELESS DRIVERS

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index cfb22e2..9ab3703 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6069,6 +6069,12 @@ L:	devel@driverdev.osuosl.org
 S:	Maintained
 F:	drivers/staging/
 
+STAGING - AGERE HERMES II and II.5 WIRELESS DRIVERS
+M:	Henk de Groot <pe1dnn@amsat.org>
+S:	Odd Fixes
+F:	drivers/staging/wlags49_h2/
+F:	drivers/staging/wlags49_h25/
+
 STAGING - ASUS OLED
 M:	Jakub Schmidtke <sjakub@gmail.com>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 13/14] MAINTAINERS: Add STAGING - XGI Z7,Z9,Z11 PCI DISPLAY DRIVER

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9ab3703..bd46c4f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6136,6 +6136,11 @@ M:	Pavel Machek <pavel@ucw.cz>
 S:	Odd Fixes
 F:	drivers/staging/winbond/
 
+STAGING - XGI Z7,Z9,Z11 PCI DISPLAY DRIVER
+M:	Arnaud Patard <apatard@mandriva.com>
+S:	Odd Fixes
+F:	drivers/staging/xgifb/
+
 STARFIRE/DURALAN NETWORK DRIVER
 M:	Ion Badulescu <ionut@badula.org>
 S:	Odd Fixes
-- 
1.7.6.131.g99019

[PATCH 14/14] MAINTAINERS: Remove se401 entry

[Joe Perches]

Commit b287db119edb ("se401: remove last V4L1 driver")
removed the files, remove the entry.

cc: Hans Verkuil <hverkuil@xs4all.nl>
cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Joe Perches <joe@perches.com>
---
 MAINTAINERS |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index bd46c4f..7c11854 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6638,13 +6638,6 @@ W:	http://pegasus2.sourceforge.net/
 S:	Maintained
 F:	drivers/net/usb/rtl8150.c
 
-USB SE401 DRIVER
-L:	linux-usb@vger.kernel.org
-W:	http://www.chello.nl/~j.vreeken/se401/
-S:	Orphan
-F:	Documentation/video4linux/se401.txt
-F:	drivers/staging/se401/
-
 USB SERIAL BELKIN F5U103 DRIVER
 M:	William Greathouse <wgreathouse@smva.com>
 L:	linux-usb@vger.kernel.org
-- 
1.7.6.131.g99019

Re: [PATCH 00/14] MAINTAINERS: Add staging

[Greg KH]

On Tue, Jul 05, 2011 at 09:42:00AM -0700, Joe Perches wrote:
> If you've changed your mind, here are the parts that apply
> from the original submission in June, 2010.
> 
> Added a removal of one deleted section as well.

Ah, what the hell, now applied...

Re: [PATCH] drivers: staging: iio: adc: fix uninitialized use

[Greg KH]

On Sun, Jul 03, 2011 at 01:47:01PM +1200, Chris Forbes wrote:
> Fixed an uninitialized variable access. In the first two error paths in
> max1363_probe(), 'st' is not yet initialized, but its 'reg' member is
> accessed anyway. This would most likely crash.
> 
> The intended value for st->reg *is* available at that point in 'reg',
> so just use that directly.

This doesn't apply anymore, care to redo it against the latest
staging-next branch and resend?

thanks,

greg k-h

Re: [PATCH] drivers: staging: iio: adc: fix uninitialized use

[Chris Forbes]

Looks one of Dan Carpenter's patches in the staging-next tree -- f88af7e --
already fixes this; disregard my patch.

-- Chris

On Wed, Jul 6, 2011 at 3:36 PM, Greg KH <greg@kroah.com> wrote:
> On Sun, Jul 03, 2011 at 01:47:01PM +1200, Chris Forbes wrote:
>> Fixed an uninitialized variable access. In the first two error paths in
>> max1363_probe(), 'st' is not yet initialized, but its 'reg' member is
>> accessed anyway. This would most likely crash.
>>
>> The intended value for st->reg *is* available at that point in 'reg',
>> so just use that directly.
>
> This doesn't apply anymore, care to redo it against the latest
> staging-next branch and resend?
>
> thanks,
>
> greg k-h
>

Re: [PATCH] drivers: staging: iio: adc: fix uninitialized use

[Greg KH]

On Wed, Jul 06, 2011 at 03:57:53PM +1200, Chris Forbes wrote:
> Looks one of Dan Carpenter's patches in the staging-next tree -- f88af7e --
> already fixes this; disregard my patch.

Consider it disregarded.