From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756462Ab1GDOZi (ORCPT ); Mon, 4 Jul 2011 10:25:38 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:64492 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753459Ab1GDOZh (ORCPT ); Mon, 4 Jul 2011 10:25:37 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH for 3.0] AT91: Change nand buswidth logic to match hardware default configuration Date: Mon, 4 Jul 2011 16:25:25 +0200 User-Agent: KMail/1.12.2 (Linux/2.6.37; KDE/4.3.2; x86_64; ; ) Cc: Nicolas Ferre , patrice.vilchez@atmel.com, linux-kernel@vger.kernel.org References: <1309515924-22531-1-git-send-email-nicolas.ferre@atmel.com> <4E1189BD.509@atmel.com> In-Reply-To: <4E1189BD.509@atmel.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201107041625.25972.arnd@arndb.de> X-Provags-ID: V02:K0:zrPQiVTu/UFmZ4dc2GWQTCyzHBvqktO5cFLvcsrd0pR uBZRAt2D3KecJyEUwewjRIjp+mFEzyIIaBBcbCLpMd4+SvzatV gEbxO2QNEDjOo+Nu/GTyy0YGY9NqZjbuU1xUXbGSGrKUj2Pc0P FL7paQKRt0TNv4O1De0DlgXQhWGzSV81tFMbMOOCoz87q3rDMf gt5q/7CB0YTtuuEPSznDg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 04 July 2011, Nicolas Ferre wrote: > Le 01/07/2011 12:25, Nicolas Ferre : > > The recently modified nand buswitth configuration is not aligned with > > board reality: the double footprint on boards is always populated with 8bits > > buswidth nand flashes. > > So we have to consider that without particular configuration the 8bits > > buswidth is selected by default. > > Moreover, the previous logic was always using !board_have_nand_8bit(), we > > change it to a simpler: board_have_nand_16bit(). > > > > Signed-off-by: Nicolas Ferre > > Tested-by: Ludovic Desroches > > Arnd, > > Can you please handle this parch for 3.0-final as a bug fix through the > arm-soc.git tree? > > You can queue it in addition of the pull request sent by > Jean-Christophe: "AT91: Fix pull requset". Ok, I've integrated it in the branch and will send the pull request. My preference would be to see fixes this late in the cycle more minmal. This patch does two things: 1. change the polarity of the system_rev bit as a bug fix and 2. change the polarity of the function reading it as a cleanup. Both changes look absolutely ok, but it's better to do the cleanup for the next kernel. In this case, studying the patch more closely shows that it's very harmless, but I'd rather not have to look that closely. Am I correct that the bug is a regression against 2.6.39? Arnd