Re: [patch 0/9] kdump: Patch series for s390 support

Michael Holzheu
2011-07-26T09:44:25Z

On Mon, 2011-07-25 at 12:02 -0400, Vivek Goyal wrote:
> On Fri, Jul 22, 2011 at 11:33:11AM +0200, Michael Holzheu wrote:

[snip]

> > crash_kexec can be entered by e.g.:
> > * panic -> kdump shutdown action -> crash_kexec
> > * panic -> s390 dump shutdown action -> auto IPL dump tool -> s390_kdump_entry -> crash_kexec
>
> So after panic() You will still jump to dump tools?

This is our current mechanism to create an automatic dump in case of
panic. I do not see a reason to change that now.

> The only thing you
> need to do there is installing program check handler and could have been
> easily done in kernel too.
>
> > * hard hang -> manual IPL dump tool -> s390_kdump_entry -> crash_kexec
>
> This one makes sense as kernel is hard hung and dump tools need to
> force crash_kexec() now. It is more like x86 NMI handler.
>
> >
> > Handling for corrupted kdump:
> >
> > New idea for returning to dump tools in case of program check:
> > We could force a program check for s390, if purgatory checksum
> > fails. Then we would automatically return to stand-alone dump
> > tools.
> >
> > The flow would look like the following in this case:
> >
> > IPL dump tool -> s390_kdump_entry -> crash_kexec +--> purgatory -+->[checksum ok]---> kdump
> > ^ | |
> > | | [checksum fail]
> > | | |
> > | | [forced program check]
> > +------[program check]---------------------+ |
> > | |
> > +----------------------------------------------------------+
> >
> > Then of course also the kernel code would have to install a special
> > program check handler before calling purgatory.
>
> If kernel code is going to install the program check handler before
> calling purgatory, then we don't need to jump to dump tools at all
> after panic()?

Independent from hard wait or panic, if dump tools have control, we want
to jump back to the dump tools code in order to be able to create
full-blown dump as backup method.

I think we now have a design, where almost no change of your kdump
framework is needed. I will resend the updated patch series.

Michael