Re: [PATCH 0/3] aat2870: Adding mfd, backlight and regulator drivers

Samuel Ortiz
2011-07-04T17:59:07Z

Hi Jin,

On Wed, Jun 29, 2011 at 11:06:49PM +0900, Jin Park wrote:
> Changing subject because the patch was separated.
> Adding relevant maintainers for backlight and regulator.
>
> Hi Samuel,
>
> > Before reviewing this patch, could you please do the following:
> >
> > 1) Split it into 3 actual patches: the MFD one, the regulator one and the
> > backlight one.
> I have separated the patch to mfd, backlight and regulator.
>
> > 2) Add the relevant maintainers (See MAINTAINERS) if you want to get a proper
> > regulator and backlight driver review.
> I submitting the patches with relevant maintainers.
>
> > You also need to take the io_lock mutex here, to prevent someone else to write
> > a different value to your register between your read and write.
> > So what you typically want is an unlocked version of aat2870_[read|write]
> > (let's say we call it __aat2870_[read|write]). Then your aat2870_[read|write]
> > become wrappers around the __aat2870_[read|write] with the lock taken. And
> > your update_bits routine can use __aat2870_[read|write] with the lock taken
> > from the beginning.
> I have modified mfd driver according to your comment.
All 3 patches applied, although I'd appreciate to get an ACK from the
backlight maintainer.

Cheers,
Samuel.

--
Intel Open Source Technology Centre