From: Anton Blanchard <anton@samba.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: David Ahern <dsahern@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf report/annotate: Add option to specify a CPU range
Date: Mon, 4 Jul 2011 21:51:40 +1000 [thread overview]
Message-ID: <20110704215140.01b5ecaa@kryten> (raw)
In-Reply-To: <20110701111641.GE20990@elte.hu>
Hi,
Ingo Molnar <mingo@elte.hu> wrote:
> * David Ahern <dsahern@gmail.com> wrote:
> > It would be better to make this a function that all 3 commands
> > reference -- something like perf_session__cpu_bitmap(session,
> > cpu_list, cpu_bitmap) in util/session.c
>
> Agreed. I can see how it ended up looking like this (fixing only perf
> report, then adding it to top, then to script), but at this stage it
> really calls for one helper that all three commands can utilize.
Yeah, it was dying to be consolidated. New version on the way.
> Very nice enhancement otherwise - might i suggest a 'perf top' hotkey
> as well to limit the output to certain CPUs only? :-)
Good idea :) I'll have a go at it.
Anton
next prev parent reply other threads:[~2011-07-04 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 5:07 [PATCH] perf report/annotate: Add option to specify a CPU range Anton Blanchard
2011-06-29 18:07 ` David Ahern
2011-06-30 3:15 ` Anton Blanchard
2011-06-30 3:16 ` Anton Blanchard
2011-06-30 3:56 ` David Ahern
2011-07-01 11:16 ` Ingo Molnar
2011-07-04 11:51 ` Anton Blanchard [this message]
2011-07-04 11:57 ` [PATCH] perf report/annotate/script: " Anton Blanchard
2011-07-05 12:56 ` [tip:perf/core] " tip-bot for Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704215140.01b5ecaa@kryten \
--to=anton@samba.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox