From: Don Zickus <dzickus@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
Stephane Eranian <eranian@google.com>,
Lin Ming <ming.m.lin@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip, final] perf, x86: Add hw_watchdog_set_attr() in a sake of nmi-watchdog on P4
Date: Tue, 5 Jul 2011 08:24:05 -0400 [thread overview]
Message-ID: <20110705122405.GU3765@redhat.com> (raw)
In-Reply-To: <20110705114437.GC15654@elte.hu>
On Tue, Jul 05, 2011 at 01:44:37PM +0200, Ingo Molnar wrote:
> > Probably I miss something and you mean something completely different?
>
> What i am missing is that you have not pointed out the *core problem*
> you are fixing and it's not obvious from the changelog either!
Cyril,
I think you didn't explain the fact that without this patch if you enable
nmi_watchdog, then the 'perf' tool doesn't work on a P4. This is bad for
end users. It seems like with all the P4 register coupling an end user
can run either the nmi_watchdog _or_ perf but not both.
For RHEL-6 this was bad because we like to enable the nmi_watchdog.
This patch does some magic and allows the end user to use the nmi_watchdog
_and_ perf concurrently (a common expected behaviour).
I hope that clears things up Ingo.
Cheers,
Don
next prev parent reply other threads:[~2011-07-05 12:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 10:03 [PATCH -tip, final] perf, x86: Add hw_watchdog_set_attr() in a sake of nmi-watchdog on P4 Cyrill Gorcunov
2011-07-05 10:20 ` Ingo Molnar
2011-07-05 10:34 ` Cyrill Gorcunov
2011-07-05 10:59 ` Ingo Molnar
2011-07-05 11:05 ` Cyrill Gorcunov
2011-07-05 11:20 ` Ingo Molnar
2011-07-05 11:36 ` Cyrill Gorcunov
2011-07-05 11:44 ` Ingo Molnar
2011-07-05 11:49 ` Cyrill Gorcunov
2011-07-05 12:14 ` Cyrill Gorcunov
2011-07-05 13:10 ` Ingo Molnar
2011-07-05 13:17 ` Peter Zijlstra
2011-07-05 13:31 ` Ingo Molnar
2011-07-05 14:19 ` Cyrill Gorcunov
2011-07-08 12:44 ` Ingo Molnar
2011-07-05 14:20 ` Peter Zijlstra
2011-07-05 14:40 ` Peter Zijlstra
2011-07-05 14:56 ` Ingo Molnar
2011-07-05 15:25 ` Cyrill Gorcunov
2011-07-06 7:01 ` Cyrill Gorcunov
2011-07-08 12:49 ` Ingo Molnar
2011-07-08 13:01 ` Cyrill Gorcunov
2011-07-08 13:09 ` Ingo Molnar
2011-07-08 13:12 ` Cyrill Gorcunov
2011-07-05 13:26 ` Cyrill Gorcunov
2011-07-05 12:24 ` Don Zickus [this message]
2011-07-05 12:26 ` Cyrill Gorcunov
2011-07-05 12:44 ` Don Zickus
2011-07-05 12:56 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705122405.GU3765@redhat.com \
--to=dzickus@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox