From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: ashishj3 <ashish.jangam@kpitcummins.com>
Cc: linaro-dev@lists.linaro.org, lrg@slimlogic.co.uk,
linux-kernel@vger.kernel.org, Dajun <dajun.chen@diasemi.com>
Subject: Re: [Patch 5/11] Regulator: DA9052 regulator support v2
Date: Tue, 5 Jul 2011 17:28:43 +0100 [thread overview]
Message-ID: <20110705162843.GA13707@sirena.org.uk> (raw)
In-Reply-To: <1309353363.4448.10.camel@L-0532.kpit.com>
On Wed, Jun 29, 2011 at 06:46:03PM +0530, ashishj3 wrote:
> +static int verify_range(struct da9052_regulator_info *info,
> + int min_uV, int max_uV)
> +{
> + if (min_uV < info->min_uV || min_uV > info->max_uV)
> + return -EINVAL;
> + if (max_uV < info->min_uV || max_uV > info->max_uV)
> + return -EINVAL;
This is broken, think about what it's trying to do - it's trying to
check that the regulator can deliver a voltage within the requested
range. These checks don't help with that.
next prev parent reply other threads:[~2011-07-05 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 13:16 [Patch 5/11] Regulator: DA9052 regulator support v2 ashishj3
2011-07-05 10:31 ` ashishj3
2011-07-05 16:28 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-29 13:12 ashishj3
2011-07-06 9:11 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705162843.GA13707@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=dajun.chen@diasemi.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox