From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752794Ab1GERt3 (ORCPT ); Tue, 5 Jul 2011 13:49:29 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:52563 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751252Ab1GERt2 (ORCPT ); Tue, 5 Jul 2011 13:49:28 -0400 Date: Tue, 5 Jul 2011 21:49:22 +0400 From: Vasiliy Kulikov To: kernel-hardening@lists.openwall.com Cc: Alan Cox , Ingo Molnar , Andrew Morton , James Morris , Namhyung Kim , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [kernel-hardening] Re: [PATCH v2] kernel: escape non-ASCII and control characters in printk() Message-ID: <20110705174922.GA6419@albatros> References: <20110626202518.GA4915@albatros> <20110626220126.GA24004@elte.hu> <20110627083633.GA5846@albatros> <20110627104058.45e93c41@pyx> <20110627183829.GA16033@albatros> <20110701143757.GA22567@albatros> <20110701154947.133c30f5@lxorguk.ukuu.org.uk> <20110703100131.GA2472@albatros> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 03, 2011 at 10:42 -0700, Linus Torvalds wrote: > So saying "%s is for pure 7-bit ASCII with no control codes" is > annoying, but would really fix it. Hmm.. It breaks usb UTF-8 strings for sure. I see some printks in debugging code. There might be other users of UTF-8 strings fed to printk(). -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments