* [PATCH] sm501: When registering the GPIO, turn on the GPIO unit's power
@ 2011-07-06 3:41 Josh Triplett
0 siblings, 0 replies; only message in thread
From: Josh Triplett @ 2011-07-06 3:41 UTC (permalink / raw)
To: Samuel Ortiz, Paul Mundt, Ben Dooks
Cc: linuxppc-dev, linux-kernel, psas-avionics
When attempting to use GPIO via the sm501 unit on the TQM5200 board,
GPIO operations would only function if during the same boot u-boot's
"fkt led" command had initialized the sm501. Comparing the sm501's
registers with and without running the "fkt led" command turned up one
significant difference: u-boot had enabled the GPIO power gate.
Changing the Linux sm501 driver to enable the GPIO power gate allows
GPIO to work without first initializing it with u-boot.
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
drivers/mfd/sm501.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index df3702c..d7a0ab9 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -1089,6 +1089,7 @@ static int __devinit sm501_register_gpio(struct sm501_devdata *sm)
goto err_low_chip;
}
+ sm501_unit_power(sm->dev, SM501_GATE_GPIO, 1);
gpio->registered = 1;
return 0;
@@ -1118,6 +1119,8 @@ static void sm501_gpio_remove(struct sm501_devdata *sm)
if (!sm->gpio.registered)
return;
+ sm501_unit_power(sm->dev, SM501_GATE_GPIO, 0);
+
ret = gpiochip_remove(&gpio->low.gpio);
if (ret)
dev_err(sm->dev, "cannot remove low chip, cannot tidy up\n");
--
1.7.5.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-07-06 3:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-06 3:41 [PATCH] sm501: When registering the GPIO, turn on the GPIO unit's power Josh Triplett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox