From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873Ab1GFLQX (ORCPT ); Wed, 6 Jul 2011 07:16:23 -0400 Received: from mail-fx0-f52.google.com ([209.85.161.52]:63902 "EHLO mail-fx0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576Ab1GFLQW (ORCPT ); Wed, 6 Jul 2011 07:16:22 -0400 Date: Wed, 6 Jul 2011 15:16:16 +0400 From: Anton Vorontsov To: tommy.lin@caviumnetworks.com Cc: "'Tommy Lin'" , "'Wim Van Sebroeck'" , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, "Lin, Mac" Subject: Re: [PATCH 2/2] watchdog: mpcore_wdt Add reload value setting for CNS3xxx hardware Message-ID: <20110706111616.GA18967@oksana.dev.rtsoft.ru> References: <1309867548-7842-1-git-send-email-tommy.lin@caviumnetworks.com> <20110705140559.GA15771@oksana.dev.rtsoft.ru> <281B1F8BAB4D4BDABE7568809A0AEC1A@starsemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <281B1F8BAB4D4BDABE7568809A0AEC1A@starsemi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 06, 2011 at 06:05:37PM +0800, Tommy Lin wrote: > Hi, I just found another patch that can solve the watchdog counter reload > issue. Please ignore this patch, since it should not acceptable to use > #ifdefs. OK, great. Do I understand correctly that without Vitaly's patch, your first patch is somewhat useless, as the watchdog will not work or will work incorrectly? So should I postpone merging patch 1/2 until Vitaly's patch hit mainline? Thanks, -- Anton Vorontsov Email: cbouatmailru@gmail.com