From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: mingo@elte.hu, rtc-linux@googlegroups.com, dannf@hp.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH] x86: enable rtc-efi
Date: Wed, 6 Jul 2011 12:42:08 +0100 [thread overview]
Message-ID: <20110706114208.GA16578@srcf.ucam.org> (raw)
In-Reply-To: <4E142659020000780004C50D@nat28.tlf.novell.com>
On Wed, Jul 06, 2011 at 08:09:45AM +0100, Jan Beulich wrote:
> >>> On 05.07.11 at 20:29, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > You haven't removed this from the IA64 code. Isn't that going to result
> > in registering the same device twice?
>
> How would code under arch/ia64/ and code under arch/x86/ ever
> manage to register the same device twice?
Gah. Sorry, I misread and thought thsi was in the generic code too.
> >> +static int __init rtc_init(void)
> >> +{
> >> + if (efi_enabled && platform_device_register(&rtc_efi_dev) < 0)
> >> + printk(KERN_ERR "unable to register rtc device...\n");
> >
> > Ought to -ENODEV if efi isn't present? The error message should also be
> > more verbose.
>
> I would agree on the -ENODEV part, but the error message is what
> the original ia64 code (which I simply copied over and modified
> slightly) has, so if a change is needed it ought to be done there first
> I would think. Additionally I can't really see what meaningful addition
> to the error message you envision.
EFI is the only way to access the rtc on IA64, whereas on x86 you'll
almost certainly also have direct hardware access as well. Make it clear
which rtc device you're unable to register.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-07-06 11:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 7:38 [PATCH] x86: enable rtc-efi Jan Beulich
2011-07-05 18:02 ` Matthew Garrett
2011-07-05 18:29 ` Matthew Garrett
2011-07-06 7:09 ` Jan Beulich
2011-07-06 11:42 ` Matthew Garrett [this message]
[not found] <4E16B5DB0200007800072A2D@nat28.tlf.novell.com>
2011-07-08 7:09 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706114208.GA16578@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=JBeulich@novell.com \
--cc=dannf@hp.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).