Re: [PATCH V2 6/6] mpcore_wdt: Move declarations in a separate header

Arnd Bergmann
2011-07-06T11:59:11Z

On Tuesday 05 July 2011, Vitaly Kuzmichev wrote:
> Signed-off-by: Vitaly Kuzmichev <vkuzmichev@mvista.com>
> ---
> drivers/watchdog/mpcore_wdt.c | 26 +-------------------------
> drivers/watchdog/mpcore_wdt.h | 40 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 41 insertions(+), 25 deletions(-)
> create mode 100644 drivers/watchdog/mpcore_wdt.h

I don't see the point in this. IMHO it's better to leave the definitions
in the same file that uses them, because they are not shared across
multiple files.

If you intend to share them in the future, you should explain that
in the changelog.

Arnd