From: Greg KH <gregkh@suse.de>
To: "Prashant P. Shah" <pshah.mumbai@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: msm: fixed style issues found by checkpatch.pl
Date: Wed, 6 Jul 2011 08:57:20 -0700 [thread overview]
Message-ID: <20110706155720.GA16625@suse.de> (raw)
In-Reply-To: <20110706074934.GA935@mail.fossee.in>
On Wed, Jul 06, 2011 at 01:19:34PM +0530, Prashant P. Shah wrote:
> This is a patch to the msm drivers that fixes many style issues
> found by the checkpatch.pl tool
> - extra spaces
> - invalid code indent
> - extra braces
> - invalid comment style
>
> Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com>
How about one patch per thing you changed please?
So that would be one patch for fixing extra braces, one for extra
spaces, and so on. That makes it easier to review.
greg k-h
next prev parent reply other threads:[~2011-07-06 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 7:49 [PATCH] Staging: msm: fixed style issues found by checkpatch.pl Prashant P. Shah
2011-07-06 15:57 ` Greg KH [this message]
2011-07-06 15:57 ` Greg KH
2011-07-06 16:15 ` Prashant Shah
2011-07-06 16:17 ` Prashant Shah
2011-07-06 19:26 ` Greg KH
2011-07-06 21:37 ` David Brown
2011-07-06 21:43 ` Greg KH
2011-07-06 22:53 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706155720.GA16625@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pshah.mumbai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox