From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756042Ab1GFUEh (ORCPT ); Wed, 6 Jul 2011 16:04:37 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:44313 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755435Ab1GFUEf (ORCPT ); Wed, 6 Jul 2011 16:04:35 -0400 Date: Wed, 6 Jul 2011 13:04:31 -0700 From: Dmitry Torokhov To: Axel Lin Cc: linux-kernel@vger.kernel.org, Thomas Renninger , Anisse Astier , Matthew Garrett , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] platform-drivers-x86: msi-wmi: add missing sparse_keymap_free in msi_wmi_init error path Message-ID: <20110706200430.GD6086@core.coreip.homeip.net> References: <1309921520.26847.3.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1309921520.26847.3.camel@phoenix> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 06, 2011 at 11:05:20AM +0800, Axel Lin wrote: > Signed-off-by: Axel Lin Acked-by: Dmitry Torokhov > --- > drivers/platform/x86/msi-wmi.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c > index c832e33..6f40bf2 100644 > --- a/drivers/platform/x86/msi-wmi.c > +++ b/drivers/platform/x86/msi-wmi.c > @@ -272,6 +272,7 @@ static int __init msi_wmi_init(void) > err_free_backlight: > backlight_device_unregister(backlight); > err_free_input: > + sparse_keymap_free(msi_wmi_input_dev); > input_unregister_device(msi_wmi_input_dev); > err_uninstall_notifier: > wmi_remove_notify_handler(MSIWMI_EVENT_GUID); > -- > 1.7.4.1 > > > -- Dmitry