From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: ashishj3 <ashish.jangam@kpitcummins.com>,
grant@secretlab.ca, arnd@arndb.de, jic23@cam.ac.uk,
linux-kernel@vger.kernel.org, Dajun <dajun.chen@diasemi.com>,
linaro-dev@lists.linaro.org
Subject: Re: [PATCH 02/11] GPIO: DA9052 GPIO module v3
Date: Wed, 6 Jul 2011 15:44:42 -0700 [thread overview]
Message-ID: <20110706224442.GA13144@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110706163656.GF5805@ponder.secretlab.ca>
On Wed, Jul 06, 2011 at 10:36:56AM -0600, Grant Likely wrote:
> It looks like this needs to be merged via the MFD tree since it
> depends on the core da9052 driver patch.
Actually that's not such an issue for new MFDs - since the function
drivers all depend on the core driver they can't be enabled in Kconfig
until the MFD part has been merged so don't do any harm.
> > +static int da9052_gpio_to_irq(struct gpio_chip *gc, u32 offset)
> > +{
> > + struct da9052_gpio *gpio = to_da9052_gpio(gc);
> > + struct da9052 *da9052 = gpio->da9052;
> > + return da9052->irq_base + DA9052_IRQ_GPI0 + offset;
> Who allocates the irq_descs for these irqs?
SoP for MFDs is to do this in the core as part of the larger block of
interrupts, the core driver is doing this.
prev parent reply other threads:[~2011-07-06 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 10:32 [PATCH 02/11] GPIO: DA9052 GPIO module v3 ashishj3
2011-07-06 10:53 ` Arnd Bergmann
2011-07-06 15:04 ` Mark Brown
2011-07-06 16:36 ` Grant Likely
2011-07-06 22:44 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706224442.GA13144@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=ashish.jangam@kpitcummins.com \
--cc=dajun.chen@diasemi.com \
--cc=grant.likely@secretlab.ca \
--cc=grant@secretlab.ca \
--cc=jic23@cam.ac.uk \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox