From: Dan Carpenter <error27@gmail.com>
To: Denis Kirjanov <kirjanov@gmail.com>
Cc: Ravishankar <ravishankarkm32@gmail.com>,
devel@driverdev.osuosl.org, gregkh@suse.de,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 5/5] Staging: comedi: fix warning issue in unioxx5.c
Date: Thu, 7 Jul 2011 12:26:53 +0300 [thread overview]
Message-ID: <20110707092653.GL18655@shale.localdomain> (raw)
In-Reply-To: <CAHj3AVkz11sxubOyoJBwh6aa+SO1TGh3rYCwPSr-SJ8V1fF4EQ@mail.gmail.com>
On Thu, Jul 07, 2011 at 12:28:21PM +0400, Denis Kirjanov wrote:
> I wonder if this patch improves code readability
>
I would like for the line width warning to be removed or that we
would allow longer lines. I don't see a lot of value in it and it's
all to common to see code that does stuff like this:
foo->
bar_fw_baz
[10 + 1
+ 1]
= x;
But I've given up hoping that it will change. People are going to
keep submitting these patches until we merge one of them so we might
as well merge the half way decent one that gets submitted.
regards,
dan carpenter
next prev parent reply other threads:[~2011-07-07 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 1/2]Staging: comedi: fix line over 80 character warning issues in unioxx5.c>
2011-07-07 7:00 ` [PATCH 5/5] Staging: comedi: fix warning issue in unioxx5.c Ravishankar
2011-07-07 8:28 ` Denis Kirjanov
2011-07-07 9:26 ` Dan Carpenter [this message]
2011-07-07 9:01 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110707092653.GL18655@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=kirjanov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox