public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	David Woodhouse <dwmw2@infradead.org>,
	David Brown <davidb@codeaurora.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
Subject: Re: [git pull] IOMMU updates for 3.1
Date: Thu, 7 Jul 2011 12:58:22 +0200	[thread overview]
Message-ID: <20110707105822.GA8227@elte.hu> (raw)
In-Reply-To: <20110707105204.GE1956@amd.com>


* Roedel, Joerg <Joerg.Roedel@amd.com> wrote:

> On Thu, Jul 07, 2011 at 05:45:58AM -0400, Ingo Molnar wrote:
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git iommu-3.1
> > Fails to build with INTR_REMAP=y && CONFIG_DMAR=n:
> > 
> >  arch/x86/built-in.o: In function `lapic_resume':
> >  apic.c:(.text+0x16329): undefined reference to `intr_remapping_enabled'
> >  apic.c:(.text+0x1651d): undefined reference to `intr_remapping_enabled'
> >  apic.c:(.text+0x1652b): undefined reference to `reenable_intr_remapping'
> >  [...]
> 
> Fixed with:
> 
> commit 6b385b46ee17d7e1a68d3411b8cdb2342e0f0445
> Author: Joerg Roedel <joerg.roedel@amd.com>
> Date:   Thu Jul 7 12:18:48 2011 +0200
> 
>     iommu/core: Fix build with INTR_REMAP=y && CONFIG_DMAR=n
>     
>     IOMMU_API is not selected when no DMA remapping driver is
>     selected, but the whole drivers/iommu/ directory is only
>     built with IOMMU_API=y. Fixed with this patch by including
>     the directory with IOMMU_SUPPORT instead.
>     
>     Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>

Next time around please add a Reported-by line ...

Anyway, i pulled it and started testing it.

Thanks,

	Ingo

  reply	other threads:[~2011-07-07 10:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07  8:53 [git pull] IOMMU updates for 3.1 Joerg Roedel
2011-07-07  9:45 ` Ingo Molnar
2011-07-07  9:59   ` Roedel, Joerg
2011-07-07 10:52   ` Roedel, Joerg
2011-07-07 10:58     ` Ingo Molnar [this message]
2011-07-07 14:15       ` Roedel, Joerg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110707105822.GA8227@elte.hu \
    --to=mingo@elte.hu \
    --cc=Joerg.Roedel@amd.com \
    --cc=davidb@codeaurora.org \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox