From: Andrew Morton <akpm@linux-foundation.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/4] x86: Implement strict user copy checks for x86_64
Date: Thu, 7 Jul 2011 14:54:13 -0700 [thread overview]
Message-ID: <20110707145413.90578915.akpm@linux-foundation.org> (raw)
In-Reply-To: <1306865673-20560-4-git-send-email-sboyd@codeaurora.org>
On Tue, 31 May 2011 11:14:32 -0700
Stephen Boyd <sboyd@codeaurora.org> wrote:
> Strict user copy checks are only really supported on x86_32 even
> though the config option is selectable on x86_64. Add the
> necessary support to the 64 bit code to trigger copy_from_user()
> warnings at compile time.
I'm still reluctant to go and throw a pile of warnings into many
people's faces without having made an attempt to fix them.
We get a screen full of these:
inlined from 'pktgen_if_write' at net/core/pktgen.c:877:
/usr/src/devel/arch/x86/include/asm/uaccess_64.h:64: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
inlined from 'pktgen_if_write' at net/core/pktgen.c:1145:
/usr/src/devel/arch/x86/include/asm/uaccess_64.h:64: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct
In function 'copy_from_user',
...
and I don't immediately see a way of suppressing them without adding
additional code.
Ideas?
next prev parent reply other threads:[~2011-07-07 21:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 18:14 [PATCH 0/4] strict user copy checks on x86_64 Stephen Boyd
2011-05-31 18:14 ` [PATCH 1/4] [SCSI] lpfc: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning Stephen Boyd
2011-05-31 18:14 ` [PATCH 2/4] kprobes: " Stephen Boyd
2011-05-31 18:14 ` [PATCH 3/4] x86: Implement strict user copy checks for x86_64 Stephen Boyd
2011-06-30 19:19 ` Andrew Morton
2011-06-30 19:23 ` Stephen Boyd
2011-06-30 19:36 ` Andrew Morton
2011-07-06 4:33 ` Stephen Boyd
2011-07-07 21:54 ` Andrew Morton [this message]
2011-07-08 1:15 ` Stephen Boyd
2011-05-31 18:14 ` [PATCH 4/4] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110707145413.90578915.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox