From: Andrew Morton <akpm@linux-foundation.org>
To: drosenberg@vsecurity.com
Cc: chris@zankel.net, security@kernel.org,
linux-kernel@vger.kernel.org, "Oleg Nesterov" <oleg@redhat.com>
Subject: Re: [Security] [PATCH] xtensa: prevent arbitrary read in ptrace
Date: Fri, 8 Jul 2011 11:42:38 -0700 [thread overview]
Message-ID: <20110708114238.d70315b7.akpm@linux-foundation.org> (raw)
In-Reply-To: <1652523982-1310150159-cardhu_decombobulator_blackberry.rim.net-183695056-@b1.c19.bise6.blackberry>
On Fri, 8 Jul 2011 18:35:56 +0000
"Dan Rosenberg" <drosenberg@vsecurity.com> wrote:
> Sorry for the top post and any email mangling (mobile).
>
> I only used EIO to mirror the existing behavior in ptrace_getxregs(). EFAULT seems better.
ptrace_getxregs() is busted ;)
int ptrace_getxregs(struct task_struct *child, void __user *uregs)
{
...
if (!access_ok(VERIFY_WRITE, uregs, sizeof(elf_xtregs_t)))
return -EIO;
...
ret |= __copy_to_user(&xtregs->user,&ti->xtregs_user,
sizeof(xtregs->user));
return ret ? -EFAULT : 0;
}
that makes no sense.
next prev parent reply other threads:[~2011-07-08 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 18:35 [Security] [PATCH] xtensa: prevent arbitrary read in ptrace Dan Rosenberg
2011-07-08 18:42 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-08 0:03 Dan Rosenberg
2011-07-08 18:27 ` [Security] " Andrew Morton
2011-07-08 18:42 ` Oleg Nesterov
2011-07-08 19:29 ` Chris Zankel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110708114238.d70315b7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=drosenberg@vsecurity.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox