From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751386Ab1GHHSj (ORCPT ); Fri, 8 Jul 2011 03:18:39 -0400 Received: from ozlabs.org ([203.10.76.45]:49456 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750743Ab1GHHSi (ORCPT ); Fri, 8 Jul 2011 03:18:38 -0400 Date: Fri, 8 Jul 2011 17:18:36 +1000 From: Anton Blanchard To: Peter Zijlstra Cc: Paul Mackerras , Lin Ming , Ingo Molnar , Andi Kleen , Stephane Eranian , Arnaldo Carvalho de Melo , linux-kernel Subject: Re: [PATCH 1/4] perf: Add memory load/store events generic code Message-ID: <20110708171836.6465a12e@kryten> In-Reply-To: <1309960718.3282.289.camel@twins> References: <1309766525-14089-1-git-send-email-ming.m.lin@intel.com> <1309766525-14089-2-git-send-email-ming.m.lin@intel.com> <1309768420.3282.8.camel@twins> <1309769066.3282.14.camel@twins> <1309867418.3282.73.camel@twins> <20110705230217.GA9584@bloggs.ozlabs.ibm.com> <1309960718.3282.289.camel@twins> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.24.4; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, > The thing we're talking about is Intel PEBS Load Latency/Precise Store > and AMD IBS where together with a mem op retired event (mem loads > retired for Load-Latency, mem stores retired for Precise Store) > provides an additional field describing where the load/store was > sourced from. > > Such additional data would require the addition of a > PERF_SAMPLE_SOURCE field or similar, for some reason or other I was > under the impression some of the PPC chips had something similar. But > if not, it saves us having to worry about that. It does sound a lot like our event vector, where we can have up to 64 bits of information that goes with a sample. A lot of the fields relate to loads and stores, but there are other fields (eg pipeline information at the point the sample was taken). So we could definitely use a field to capture this. Anton