From: Karel Zak <kzak@redhat.com>
To: Nao Nishijima <nao.nishijima.xt@hitachi.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
James.Bottomley@HansenPartnership.com, kay.sievers@vrfy.org,
jcm@redhat.com, greg@kroah.com,
dle-develop@lists.sourceforge.net,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
yrl.pp-manager.tt@hitachi.com, dgilbert@interlog.com,
stefanr@s5r6.in-berlin.de, hare@suse.de
Subject: Re: [RFC PATCH 0/4] Persistent device name using alias name
Date: Fri, 8 Jul 2011 21:45:01 +0200 [thread overview]
Message-ID: <20110708194501.GU6418@nb.net.home> (raw)
In-Reply-To: <20110708084547.2091.55262.stgit@ltc197.sdl.hitachi.co.jp>
On Fri, Jul 08, 2011 at 05:45:47PM +0900, Nao Nishijima wrote:
> This patch series provides an "alias name" of the disk into kernel and procfs
> messages. The user can assign a preferred name to an alias name of the device.
>
> Based on previous discussion (*), I changed patches as follows
> - This is "alias name"
> - An "alias name" is stored in gendisk struct
> - Add document to Documentation/ABI/testing/sysfs-block
> - When the user changes an "alias name", kernel notifies udev
>
> (*) http://marc.info/?l=linux-scsi&m=130812625531219&w=2
>
[...]
> [localhost]# cat /proc/partitions
> major minor #blocks name
>
> 8 0 12582912 foo
> 8 1 12582878 foo1
> 8 0 8388608 sdb
> 8 1 512000 sdb1
> 8 2 7875584 sdb2
If there is not /dev/foo and /sys/block/foo then the patch introduces
a REGRESSION.
The names from /proc/partitions are used in many applications
(libblkid, fdisk, ...) for many many years. The applications will not
work as expected.
It's crazy to assume that all the applications will be improved to
translate the "pretty name" from /proc/partitions by /sys/block/<maj>:<min>.
Note, it's pretty naive to expect that people will use the pretty
names for printk()/dmesg only. I'm absolutely sure that it's will be
expected (by end-users) in /etc/fstab, mount, df, fdisk, ...
It's will be necessary to modify all these utils.
The patch is opening Pandora's box :-(
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-07-08 19:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 8:45 [RFC PATCH 0/4] Persistent device name using alias name Nao Nishijima
2011-07-08 8:46 ` [RFC PATCH 1/4] block: add a new attribute "alias name" in gendisk structure Nao Nishijima
2011-07-08 8:46 ` [RFC PATCH 2/4] sd: modify printk for alias_name Nao Nishijima
2011-07-09 5:42 ` [PATCH] scsi: Make functions out of logging macros Joe Perches
2011-07-09 13:32 ` Nao Nishijima
2011-07-08 8:46 ` [RFC PATCH 3/4] fs: modify disk_name() for alias name Nao Nishijima
2011-07-08 8:46 ` [RFC PATCH 4/4] sd: cleanup " Nao Nishijima
2011-07-08 14:54 ` [RFC PATCH 0/4] Persistent device name using " Greg KH
2011-07-08 15:41 ` Kay Sievers
2011-07-08 15:47 ` Greg KH
2011-07-08 15:54 ` James Bottomley
2011-07-08 16:04 ` Greg KH
2011-07-08 16:17 ` James Bottomley
2011-07-08 16:32 ` Greg KH
2011-07-08 16:15 ` Kay Sievers
2011-07-08 16:38 ` Kay Sievers
2011-07-11 11:47 ` Hannes Reinecke
2011-07-09 6:11 ` Masami Hiramatsu
2011-08-03 17:16 ` Borislav Petkov
2011-08-10 2:01 ` Masami Hiramatsu
2011-07-08 19:45 ` Karel Zak [this message]
2011-07-08 19:58 ` Greg KH
2011-07-15 6:55 ` Nao Nishijima
2011-07-15 12:48 ` Karel Zak
2011-07-16 11:40 ` Nao Nishijima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110708194501.GU6418@nb.net.home \
--to=kzak@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dgilbert@interlog.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=hare@suse.de \
--cc=jcm@redhat.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=nao.nishijima.xt@hitachi.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox