* [PATCH 6/6] Staging: comedi: fix warning issue in unioxx5.c
[not found] <[PATCH 2/2]Staging: comedi:fix warning issues in unioxx5.c>
@ 2011-07-07 8:36 ` Ravishankar
2011-07-08 20:53 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ravishankar @ 2011-07-07 8:36 UTC (permalink / raw)
To: gregkh, wfp5p; +Cc: devel, linux-kernel, Ravishankar, Ravishankar
From: Ravishankar <ravi.shankar@greenturtles.in>
This is a patch to the unioxx5.c file that fixes up a warning: line over 80 character by the checkpatch.pl tool
Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/unioxx5.c | 30 +++++++++++++++++++++---------
1 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/comedi/drivers/unioxx5.c b/drivers/staging/comedi/drivers/unioxx5.c
index 9b311c7..88dafb7 100644
--- a/drivers/staging/comedi/drivers/unioxx5.c
+++ b/drivers/staging/comedi/drivers/unioxx5.c
@@ -207,7 +207,9 @@ static int unioxx5_subdev_write(struct comedi_device *dev,
int channel, type;
channel = CR_CHAN(insn->chanspec);
- type = usp->usp_module_type[channel / 2]; /* defining module type(analog or digital) */
+ type = usp->usp_module_type[channel / 2]; /* defining module type
+ * (analog or digital)
+ */
if (type == MODULE_DIGITAL) {
if (!__unioxx5_digital_write(usp, data, channel, dev->minor))
@@ -266,9 +268,13 @@ static int unioxx5_insn_config(struct comedi_device *dev,
* change channel type on input or output) *
\* */
outb(1, usp->usp_iobase + 0);
- outb(flags, usp->usp_iobase + channel_offset); /* changes type of _one_ channel */
+ outb(flags, usp->usp_iobase + channel_offset); /* changes type of
+ * _one_ channel
+ */
@@ -316,7 +322,9 @@ static int __unioxx5_subdev_init(struct comedi_subdevice *subdev,
to = 10000;
__unioxx5_analog_config(usp, i * 2);
- outb(i + 1, subdev_iobase + 5); /* sends channel number to card */
+ outb(i + 1, subdev_iobase + 5); /* sends channel number
+ * to card
+ */
outb('H', subdev_iobase + 6); /* requests EEPROM world */
while (!(inb(subdev_iobase + 0) & TxBE))
; /* waits while writting will be allowed */
@@ -372,15 +381,18 @@ static int __unioxx5_digital_write(struct unioxx5_subd_priv *usp,
return 0;
}
- val = usp->usp_prev_wr_val[channel_offset - 1]; /* getting previous written value */
-
+ val = usp->usp_prev_wr_val[channel_offset - 1]; /* getting previous
+ * written value
+ */
if (*data)
val |= mask;
else
val &= ~mask;
outb(val, usp->usp_iobase + channel_offset);
- usp->usp_prev_wr_val[channel_offset - 1] = val; /* saving new written value */
+ usp->usp_prev_wr_val[channel_offset - 1] = val; /* saving new written
+ * value
+ */
return 1;
}
--
1.6.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/6] Staging: comedi: fix warning issue in unioxx5.c
2011-07-07 8:36 ` [PATCH 6/6] Staging: comedi: fix warning issue in unioxx5.c Ravishankar
@ 2011-07-08 20:53 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2011-07-08 20:53 UTC (permalink / raw)
To: Ravishankar; +Cc: gregkh, wfp5p, devel, linux-kernel, Ravishankar
On Thu, Jul 07, 2011 at 02:06:57PM +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@greenturtles.in>
>
> This is a patch to the unioxx5.c file that fixes up a warning: line over 80 character by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
> ---
> drivers/staging/comedi/drivers/unioxx5.c | 30 +++++++++++++++++++++---------
> 1 files changed, 21 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/unioxx5.c b/drivers/staging/comedi/drivers/unioxx5.c
> index 9b311c7..88dafb7 100644
> --- a/drivers/staging/comedi/drivers/unioxx5.c
> +++ b/drivers/staging/comedi/drivers/unioxx5.c
> @@ -207,7 +207,9 @@ static int unioxx5_subdev_write(struct comedi_device *dev,
> int channel, type;
>
> channel = CR_CHAN(insn->chanspec);
> - type = usp->usp_module_type[channel / 2]; /* defining module type(analog or digital) */
> + type = usp->usp_module_type[channel / 2]; /* defining module type
> + * (analog or digital)
> + */
That doesn't line up properly :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-08 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <[PATCH 2/2]Staging: comedi:fix warning issues in unioxx5.c>
2011-07-07 8:36 ` [PATCH 6/6] Staging: comedi: fix warning issue in unioxx5.c Ravishankar
2011-07-08 20:53 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox