From: Pavel Roskin <proski@gnu.org>
To: Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] checkpatch: suggest spaces around binary operators in strict mode
Date: Fri, 08 Jul 2011 17:41:59 -0400 [thread overview]
Message-ID: <20110708214159.7559.25740.stgit@mj.roinet.com> (raw)
Signed-off-by: Pavel Roskin <proski@gnu.org>
---
scripts/checkpatch.pl | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b0aa2c6..9431ada 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2167,6 +2167,8 @@ sub process {
if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
ERROR("need consistent spacing around '$op' $at\n" .
$hereptr);
+ } elsif ($ctx =~ /[^WCE]x[^WCE]/) {
+ CHK("spaces suggested around '$op' $at\n" . $hereptr);
}
# A colon needs no spaces before when it is
next reply other threads:[~2011-07-08 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 21:41 Pavel Roskin [this message]
2011-07-08 23:01 ` [PATCH] checkpatch: suggest spaces around binary operators in strict mode Joe Perches
2011-07-09 1:08 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110708214159.7559.25740.stgit@mj.roinet.com \
--to=proski@gnu.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox