Re: [Xen-devel] Re: [PATCH] Modpost section mismatch fix (for platform-pci-unplug.c)

Stefano Stabellini
2011-07-11T10:42:55Z

On Fri, 8 Jul 2011, Konrad Rzeszutek Wilk wrote:
> > >>Also,
> > >>I had sent another change (oneline) for the file
> > >>arch/x86/xen/platform-pci-unplug.c for check_platform_magic, looks like that has not gone into
> > >>the pull request for Linus.
> > >
> > >Oh, I didn't see it. Did you CC me on it? Can you bounce it to me please?
> > >
> > =========================
> > diff --git a/arch/x86/xen/platform-pci-unplug.c b/arch/x86/xen/platform-pci-unplug.c
> > index 25c52f9..ffcf261 100644
> > --- a/arch/x86/xen/platform-pci-unplug.c
> > +++ b/arch/x86/xen/platform-pci-unplug.c
> > @@ -35,7 +35,7 @@ EXPORT_SYMBOL_GPL(xen_platform_pci_unplug);
> > #ifdef CONFIG_XEN_PVHVM
> > static int xen_emul_unplug;
> >
> > -static int __init check_platform_magic(void)
> > +static int check_platform_magic(void)
> > {
> > short magic;
> > char protocol;
> > --
> >
>
> Yeah, that would cause an issue during suspend/resume by PVonHVM. How
> we didn't trip over this I've no idea..
>
> Anyhow, can you provide me with your Signed-off-by please and I will queue
> it right up.
>
> Stefano, you OK with this patch?
>

It is fine by me