Re: [PATCH] dell-laptop - using buffer without mutex_lock

Greg Dietsche
2011-07-09T21:27:42Z

Hi Jose,

On Fri, Jul 08, 2011 at 07:01:27PM -0300, Jose Alonso wrote:
> Using buffer->output[1] without mutex_lock()
>
> --- linux-3.0-rc6/drivers/platform/x86/dell-laptop.c.ORIG
> 2011-07-04 19:56:24.000000000 -0300
> +++ linux-3.0-rc6/drivers/platform/x86/dell-laptop.c 2011-07-08
> 18:27:02.420791868 -0300
> @@ -560,11 +560,11 @@
> else
> dell_send_request(buffer, 0, 1);
>
> + ret = buffer->output[1];
> +
> out:
> release_buffer();
> - if (ret)
> - return ret;
> - return buffer->output[1];
> + return ret;
> }
>
> static const struct backlight_ops dell_ops = {
>
>
> --

You should run this patch through scripts/checkpatch.pl as it
reports a few style issues for your patch including a missing
signed-off-by line and some spaces that should be converted to tabs.

Greg