public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] firewire: ohci: do not bind to Pinnacle cards, prevent panic
Date: Sun, 10 Jul 2011 00:23:03 +0200	[thread overview]
Message-ID: <20110710002303.2aeee41c@stein> (raw)
In-Reply-To: <20110709235410.08004e5d@stein>

When firewire-ohci is bound to a Pinnacle MovieBoard, eventually a
"Register access failure" is logged and an interrupt storm or a kernel
panic happens.  https://bugzilla.kernel.org/show_bug.cgi?id=36622

Until this is sorted out (if that is going to succeed at all), let's
just prevent firewire-ohci from touching these devices.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: <stable@kernel.org>
---
 drivers/firewire/ohci.c |    6 ++++++
 1 file changed, 6 insertions(+)

Index: b/drivers/firewire/ohci.c
===================================================================
--- a/drivers/firewire/ohci.c
+++ b/drivers/firewire/ohci.c
@@ -263,6 +263,7 @@ static char ohci_driver_name[] = KBUILD_
 #define PCI_DEVICE_ID_AGERE_FW643	0x5901
 #define PCI_DEVICE_ID_JMICRON_JMB38X_FW	0x2380
 #define PCI_DEVICE_ID_TI_TSB12LV22	0x8009
+#define PCI_VENDOR_ID_PINNACLE_SYSTEMS	0x11bd
 
 #define QUIRK_CYCLE_TIMER		1
 #define QUIRK_RESET_PACKET		2
@@ -3202,6 +3203,11 @@ static int __devinit pci_probe(struct pc
 	int i, err;
 	size_t size;
 
+	if (dev->vendor == PCI_VENDOR_ID_PINNACLE_SYSTEMS) {
+		dev_err(&dev->dev, "Pinnacle MovieBoard not yet supported\n");
+		return -ENOSYS;
+	}
+
 	ohci = kzalloc(sizeof(*ohci), GFP_KERNEL);
 	if (ohci == NULL) {
 		err = -ENOMEM;



-- 
Stefan Richter
-=====-==-== -=== -=-=-
http://arcgraph.de/sr/

       reply	other threads:[~2011-07-09 22:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110604002938.78c85881@stein>
     [not found] ` <20110604010625.1a37638e@stein>
     [not found]   ` <4DEA697A.1090104@bourrigaud.info>
     [not found]     ` <20110612145303.2099aa81@stein>
     [not found]       ` <4DF4FF4F.4020607@bourrigaud.info>
     [not found]         ` <20110612210111.3e979131@stein>
     [not found]           ` <4DF528CF.50407@bourrigaud.info>
     [not found]             ` <20110709235410.08004e5d@stein>
2011-07-09 22:23               ` Stefan Richter [this message]
     [not found]               ` <4E1A161D.1050304@ladisch.de>
2011-07-10 23:24                 ` [PATCH] firewire: ohci: do not bind to Pinnacle or Fujitsu HCI, prevent panic Stefan Richter
2011-07-10 23:30                   ` Bjørn Forbord
2011-07-10 23:50                   ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110710002303.2aeee41c@stein \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox