From: Al Viro <viro@ZenIV.linux.org.uk>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: do_signal: simplify the TS_RESTORE_SIGMASK logic
Date: Sun, 10 Jul 2011 22:08:33 +0100 [thread overview]
Message-ID: <20110710210833.GH11013@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110710182203.GA27979@redhat.com>
On Sun, Jul 10, 2011 at 08:22:03PM +0200, Oleg Nesterov wrote:
> 2. do_signal() also clears TS_RESTORE_SIGMASK if handle_signal()
> succeeds.
>
> We can move this to setup_rt_frame() as well, this avoids the
> unnecessary checks and makes the logic more clear.
> + current_thread_info()->status &= ~TS_RESTORE_SIGMASK;
> return ret;
This is broken. If setup_rt_frame() fails, you don't want to do that.
next prev parent reply other threads:[~2011-07-10 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 18:22 [PATCH] x86: do_signal: simplify the TS_RESTORE_SIGMASK logic Oleg Nesterov
2011-07-10 21:08 ` Al Viro [this message]
2011-07-11 11:39 ` Oleg Nesterov
2011-07-13 9:25 ` Matt Fleming
2011-07-13 15:23 ` Oleg Nesterov
2011-07-15 5:47 ` [tip:x86/signal] x86, do_signal: Simplify " tip-bot for Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110710210833.GH11013@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox