From: Tobias Klauser <tklauser@distanz.ch>
To: Ravishankar <ravishankarkm32@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 10/10] Staging: comedi: fix brace printk() issue in pcl818.c
Date: Mon, 11 Jul 2011 10:20:29 +0200 [thread overview]
Message-ID: <20110711082029.GL8334@distanz.ch> (raw)
In-Reply-To: <1310370712-28864-1-git-send-email-ravishankarkm32@gmail.com>
On 2011-07-11 at 09:51:52 +0200, Ravishankar <ravishankarkm32@gmail.com> wrote:
> From: Ravishankar <ravi.shankar@greenturtles.in>
>
> This is a patch to the pcl818.c file that fixes up a printk() warning found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
> ---
> drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index 2fdb8c9..4069fee 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -1777,7 +1777,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> irq);
> irq = 0; /* Can't use IRQ */
> } else {
> - printk(", irq=%u", irq);
> + printk(KERN_INFO ", irq=%u", irq);
This should be KERN_CONT.
> }
> }
> }
> @@ -1883,7 +1883,7 @@ no_dma:
> if (check_single_ended(dev->iobase)) {
> s->n_chan = this_board->n_aichan_se;
> s->subdev_flags |= SDF_COMMON | SDF_GROUND;
> - printk(", %dchans S.E. DAC", s->n_chan);
> + printk(KERN_INFO ", %dchans S.E. DAC", s->n_chan);
Ditto.
> } else {
> s->n_chan = this_board->n_aichan_diff;
> s->subdev_flags |= SDF_DIFF;
> --
> 1.6.5.2
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>
next prev parent reply other threads:[~2011-07-11 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 9/9]Staging: comedi: fix printk issue in pcl818.c>
2011-07-11 7:51 ` [PATCH 10/10] Staging: comedi: fix brace printk() issue in pcl818.c Ravishankar
2011-07-11 8:20 ` Tobias Klauser [this message]
[not found] <[PATCH]Staging: comedi:fix printk()issue in pcl818.c>
2011-07-11 8:57 ` Ravishankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711082029.GL8334@distanz.ch \
--to=tklauser@distanz.ch \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox