public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* staging/lirc_bt829: Return -ENODEV when no hardware is found.
@ 2011-07-11 15:24 Dave Jones
  0 siblings, 0 replies; only message in thread
From: Dave Jones @ 2011-07-11 15:24 UTC (permalink / raw)
  To: lfroen; +Cc: Linux Kernel, greg

sys_init_module: 'lirc_bt829'->init suspiciously returned 1, it should follow 0/-E convention
sys_init_module: loading module anyway...
Pid: 8511, comm: modprobe Tainted: G        WC  3.0.0-rc6+ #73
Call Trace:
 [<ffffffff810b3da7>] sys_init_module+0x217/0x230
 [<ffffffff815ed1d2>] system_call_fastpath+0x16/0x1b

Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/drivers/staging/lirc/lirc_bt829.c b/drivers/staging/lirc/lirc_bt829.c
index 3388102..c5a0d27 100644
--- a/drivers/staging/lirc/lirc_bt829.c
+++ b/drivers/staging/lirc/lirc_bt829.c
@@ -122,10 +122,10 @@ int init_module(void)
 
 	pdev = do_pci_probe();
 	if (pdev == NULL)
-		return 1;
+		return -ENODEV;
 
 	if (!atir_init_start())
-		return 1;
+		return -ENODEV;
 
 	strcpy(atir_driver.name, "ATIR");
 	atir_driver.minor       = -1;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-07-11 15:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-11 15:24 staging/lirc_bt829: Return -ENODEV when no hardware is found Dave Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox