From: Dave Jones <davej@redhat.com>
To: "Rafał Bilski" <rafalbilski@interia.pl>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org
Subject: Re: [PATCH] e_powersaver: Underclock checks
Date: Mon, 11 Jul 2011 19:25:17 -0400 [thread overview]
Message-ID: <20110711232517.GC20367@redhat.com> (raw)
In-Reply-To: <4E1B8404.1050909@interia.pl>
On Tue, Jul 12, 2011 at 12:15:16AM +0100, Rafał Bilski wrote:
Your email client word-wrapped your patch so it won't apply.
When you resend, there's a few small typos/grammar..
> + /* Check for systems using underclocked CPU */
> + if (!freq_failsafe_off && max_multiplier != current_multiplier) {
> + printk(KERN_INFO "eps: Your processor is running at
> different then "
> + "its maximum frequency.\n");
"is running at a different frequency than its maximum" reads a little clearer.
> + printk(KERN_INFO "eps: Some systems use underclocked CPU's\n");
> + printk(KERN_INFO "eps: Use of \"e_powersaver\" on them may cause "
> + "irreperable damage.\n");
'irreparable'.
> + if (!voltage_failsafe_off && max_voltage != current_voltage) {
> + printk(KERN_INFO "eps: Your processor is running at
> different then "
> + "its maximum voltage.\n");
similar to above.
Dave
next prev parent reply other threads:[~2011-07-11 23:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 8:37 [RFC][PATCH] cpufreq: e_powersaver: Fix checking brand for EPS_BRAND_C3 Axel Lin
2011-07-11 16:36 ` Rafał Bilski
2011-07-11 22:08 ` [PATCH] e_powersaver: Add sanity checks to code provided by VIA Rafał Bilski
2011-07-11 23:15 ` [PATCH] e_powersaver: Underclock checks Rafał Bilski
2011-07-11 23:25 ` Dave Jones [this message]
2011-07-12 17:00 ` Rafał Bilski
2011-07-13 16:40 ` Rafał Bilski
2011-07-13 16:45 ` Dave Jones
2011-07-13 22:24 ` [PATCH] e_powersaver: Add sanity checks to code provided by VIA Dave Jones
2011-07-13 23:01 ` Rafał Bilski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711232517.GC20367@redhat.com \
--to=davej@redhat.com \
--cc=axel.lin@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafalbilski@interia.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).