From: Dan Carpenter <error27@gmail.com>
To: Ravishankar <ravishankarkm32@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>
Subject: Re: [PATCH 30/30] Staging: comedi: fix printk() issue in das16m1.c
Date: Thu, 14 Jul 2011 10:41:44 +0300 [thread overview]
Message-ID: <20110714074144.GR18655@shale.localdomain> (raw)
In-Reply-To: <1310618547-8801-1-git-send-email-ravishankarkm32@gmail.com>
On Thu, Jul 14, 2011 at 10:12:27AM +0530, Ravishankar wrote:
> @@ -690,7 +690,7 @@ static int das16m1_attach(struct comedi_device *dev,
> if (!request_region(iobase + DAS16M1_82C55, DAS16M1_SIZE2,
> driver_das16m1.driver_name)) {
> release_region(iobase, DAS16M1_SIZE);
> - printk(" I/O port conflict\n");
> + printk(KERN_ERR " I/O port conflict\n");
This is a continuation of the last printk line.
> return -EIO;
> }
> dev->iobase = iobase;
> @@ -710,7 +710,7 @@ static int das16m1_attach(struct comedi_device *dev,
> } else if (irq == 0) {
> printk(", no irq\n");
> } else {
> - printk(", invalid irq\n"
> + printk(KERN_ERR ", invalid irq\n"
Same.
If you want you can just rewrite the printks completely. You're not
just limited to adding the KERN_ prefixes, you could make larger
changes than that.
regards,
dan carpenter
prev parent reply other threads:[~2011-07-14 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 3/3]Staging: comedi: fix printk warning issue in das16m1.c>
2011-07-14 4:42 ` [PATCH 30/30] Staging: comedi: fix printk() issue in das16m1.c Ravishankar
2011-07-14 7:41 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714074144.GR18655@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=ravishankarkm32@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox