From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Wendy Yuan-Hsin Chen(??????)" <yhchen@faraday-tech.com>
Cc: Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH 4/5] fusb300_udc: Add missing breaks in switch/case
Date: Thu, 14 Jul 2011 12:36:24 +0200 [thread overview]
Message-ID: <20110714103624.GG7149@linutronix.de> (raw)
In-Reply-To: <B3F95056718EDE47B73D925D2FF34506782BC2@EX1.faraday.com.tw>
* Wendy Yuan-Hsin Chen(??????) | 2011-07-14 16:36:39 [+0800]:
>>>diff --git a/drivers/usb/gadget/fusb300_udc.c
>>>b/drivers/usb/gadget/fusb300_udc.c
>>>index 06353e7..453bc0f 100644
>>>--- a/drivers/usb/gadget/fusb300_udc.c
>>>+++ b/drivers/usb/gadget/fusb300_udc.c
>>>@@ -688,10 +688,13 @@ static void fusb300_cmp_dbg_fifo(struct fusb300_ep *ep,
>>> switch (length % 4) {
>>> case 1:
>>> golden_value = *tmp;
>>>+ break;
>>> case 2:
>>> golden_value = *tmp | *(tmp + 1) << 8;
>>>+ break;
>>> case 3:
>>> golden_value = *tmp | *(tmp + 1) << 8 | *(tmp + 2) << 16;
>>>+ break;
>>> default:
>>> break;
>>>
>
>>That is in an #if 0 block. Maybe we should remove the #if 0? Yuan-Hsin?
>
>It's ok to remove the #if 0. But the warning will occur while compling.
By removing the #if 0 block I meant to remove the unused functions
fusb300_cmp_dbg_fifo() and fusb300_dbg_fifo(). There should be no
warning then.
Are you okey with this? Are those function required?
>Yuan-Hsin
Sebastian
next prev parent reply other threads:[~2011-07-14 10:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 9:28 [PATCH 0/5] treewide: Add missing breaks in switch/case Joe Perches
2011-07-10 9:28 ` [PATCH 1/5] gpio-tps65910.c: " Joe Perches
2011-07-10 10:47 ` Grant Likely
2011-07-10 9:28 ` [PATCH 2/5] tps65910-irq: " Joe Perches
2011-07-10 9:28 ` [PATCH 3/5] ath5k: " Joe Perches
2011-07-11 15:50 ` [ath5k-devel] " Pavel Roskin
2011-07-11 21:24 ` Nick Kossifidis
2011-07-10 9:28 ` [PATCH 4/5] fusb300_udc: " Joe Perches
2011-07-11 6:39 ` Felipe Balbi
2011-07-14 8:08 ` Sebastian Andrzej Siewior
2011-07-14 8:36 ` Wendy Yuan-Hsin Chen(陳元馨)
2011-07-14 10:36 ` Sebastian Andrzej Siewior [this message]
2011-07-14 13:28 ` Wendy Yuan-Hsin Chen(陳元馨)
2011-07-18 8:36 ` Felipe Balbi
2011-07-18 12:54 ` Wendy Yuan-Hsin Chen(陳元馨)
2011-07-19 19:47 ` [PATCH] usb/fusb300: remove #if 0 block Sebastian Andrzej Siewior
2011-07-26 14:52 ` Felipe Balbi
2011-07-10 9:28 ` [PATCH 5/5] dbri: Add missing breaks in switch/case Joe Perches
2011-07-10 14:36 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714103624.GG7149@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=balbi@ti.com \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yhchen@faraday-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox