Re: [PATCH 1/2] x86: Remove warning and warning_symbol from struct stacktrace_ops

[Frederic Weisbecker <fweisbec@gmail.com>]

On Thu, Jul 14, 2011 at 12:01:02PM +0100, Mel Gorman wrote:
> On Thu, May 12, 2011 at 10:32:05PM +0200, Frederic Weisbecker wrote:
> > From: Richard Weinberger <richard@nod.at>
> > 
> > Both warning and warning_symbol are nowhere used.
> > Let's get rid of them.
> > 
> > Signed-off-by: Richard Weinberger <richard@nod.at>
> > Cc: Oleg Nesterov <oleg@redhat.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Huang Ying <ying.huang@intel.com>
> > Cc: Soeren Sandmann Pedersen <ssp@redhat.com>
> > Cc: Namhyung Kim <namhyung@gmail.com>
> > Cc: x86 <x86@kernel.org>
> > Cc: H. Peter Anvin <hpa@zytor.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Robert Richter <robert.richter@amd.com>
> > Cc: Paul Mundt <lethal@linux-sh.org>
> > Link: http://lkml.kernel.org/r/1305205872-10321-2-git-send-email-richard@nod.at
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> 
> This change breaks systemtap. I know it's out of tree and systemtap
> doesn't even do anything useful with the symbols as it assigns them
> to dummy callbacks but the breakage is there.

Then it's up to systemtap developers to deal with that. We don't maintain out-of-tree.