From: Don Zickus <dzickus@redhat.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Tony Luck <tony.luck@intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 08/17] ACPI, APEI, GHES, Support disable GHES at boot time
Date: Thu, 14 Jul 2011 10:47:17 -0400 [thread overview]
Message-ID: <20110714144716.GA3080@redhat.com> (raw)
In-Reply-To: <1310534068-30547-9-git-send-email-ying.huang@intel.com>
On Wed, Jul 13, 2011 at 01:14:19PM +0800, Huang Ying wrote:
> Some machine may have broken firmware so that GHES and firmware first
> mode should be disabled. This patch adds support to that.
Does this still work if you have disabled ghes module support in the
previous patch?
Cheers,
Don
>
> Signed-off-by: Huang Ying <ying.huang@intel.com>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
> Reviewed-by: Matthew Garrett <mjg@redhat.com>
> ---
> drivers/acpi/apei/ghes.c | 8 ++++++++
> drivers/acpi/apei/hest.c | 17 +++++++++--------
> include/acpi/apei.h | 1 +
> 3 files changed, 18 insertions(+), 8 deletions(-)
>
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -77,6 +77,9 @@ struct ghes {
> };
> };
>
> +int ghes_disable;
> +module_param_named(disable, ghes_disable, bool, 0);
> +
> static int ghes_panic_timeout __read_mostly = 30;
>
> /*
> @@ -665,6 +668,11 @@ static int __init ghes_init(void)
> return -EINVAL;
> }
>
> + if (ghes_disable) {
> + pr_info(GHES_PFX "GHES is not enabled!\n");
> + return -EINVAL;
> + }
> +
> rc = ghes_ioremap_init();
> if (rc)
> goto err;
> --- a/drivers/acpi/apei/hest.c
> +++ b/drivers/acpi/apei/hest.c
> @@ -231,16 +231,17 @@ void __init acpi_hest_init(void)
> goto err;
> }
>
> - rc = apei_hest_parse(hest_parse_ghes_count, &ghes_count);
> - if (rc)
> - goto err;
> -
> - rc = hest_ghes_dev_register(ghes_count);
> - if (!rc) {
> - pr_info(HEST_PFX "Table parsing has been initialized.\n");
> - return;
> + if (!ghes_disable) {
> + rc = apei_hest_parse(hest_parse_ghes_count, &ghes_count);
> + if (rc)
> + goto err;
> + rc = hest_ghes_dev_register(ghes_count);
> + if (rc)
> + goto err;
> }
>
> + pr_info(HEST_PFX "Table parsing has been initialized.\n");
> + return;
> err:
> hest_disable = 1;
> }
> --- a/include/acpi/apei.h
> +++ b/include/acpi/apei.h
> @@ -18,6 +18,7 @@
>
> extern int hest_disable;
> extern int erst_disable;
> +extern int ghes_disable;
>
> #ifdef CONFIG_ACPI_APEI
> void __init acpi_hest_init(void);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-07-14 14:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 5:14 [PATCH 00/17] ACPI, APEI, Patches for 3.1 Huang Ying
2011-07-13 5:14 ` [PATCH 01/17] ACPI, APEI, HEST, Detect duplicated hardware error source ID Huang Ying
2011-07-14 3:28 ` Len Brown
2011-07-13 5:14 ` [PATCH 02/17] ACPI, APEI, ERST, Prevent erst_dbg from loading if ERST is disabled Huang Ying
2011-07-14 3:30 ` Len Brown
2011-07-13 5:14 ` [PATCH 03/17] ACPI, APEI, ERST, Fix erst-dbg long record reading issue Huang Ying
2011-07-14 3:32 ` Len Brown
2011-07-13 5:14 ` [PATCH 04/17] ACPI, APEI, GHES, Do not ratelimit fatal error printk before panic Huang Ying
2011-07-14 3:33 ` Len Brown
2011-07-13 5:14 ` [PATCH 05/17] ACPI, APEI, Add apei_exec_run_optional Huang Ying
2011-07-13 5:14 ` [PATCH 06/17] ACPI, APEI, Use apei_exec_run_optional in APEI EINJ and ERST Huang Ying
2011-07-13 5:14 ` [PATCH 07/17] ACPI, APEI, GHES, Prevent GHES to be built as module Huang Ying
2011-07-14 3:36 ` Len Brown
2011-07-13 5:14 ` [PATCH 08/17] ACPI, APEI, GHES, Support disable GHES at boot time Huang Ying
2011-07-14 14:47 ` Don Zickus [this message]
2011-07-15 0:31 ` Huang Ying
2011-07-15 13:33 ` Don Zickus
2011-07-13 5:14 ` [PATCH 09/17] ACPI, APEI, Add APEI bit support in generic _OSC call Huang Ying
2011-07-14 14:48 ` Don Zickus
2011-07-13 5:14 ` [PATCH 10/17] ACPI, APEI, Add WHEA _OSC support Huang Ying
2011-07-14 14:50 ` Don Zickus
2011-07-13 5:14 ` [PATCH 11/17] Add Kconfig option ARCH_HAVE_NMI_SAFE_CMPXCHG Huang Ying
2011-07-13 5:14 ` [PATCH 12/17] lib, Add lock-less NULL terminated single list Huang Ying
2011-07-13 5:14 ` [PATCH 13/17] lib, Make gen_pool memory allocator lockless Huang Ying
2011-07-13 5:14 ` [PATCH 14/17] ACPI, APEI, GHES, printk support for recoverable error via NMI Huang Ying
2011-07-13 5:14 ` [PATCH 15/17] ACPI, APEI, GHES, Error records content based throttle Huang Ying
2011-07-13 5:14 ` [PATCH 16/17] HWPoison: add memory_failure_queue() Huang Ying
2011-07-13 5:14 ` [PATCH 17/17] ACPI, APEI, GHES: Add hardware memory error recovery support Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714144716.GA3080@redhat.com \
--to=dzickus@redhat.com \
--cc=andi@firstfloor.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox