Re: [PATCH 1/2] Kconfig: Allow disabling of CONFIG_DEVPORT

Greg KH
2011-07-16T07:57:09Z

On Fri, Jul 15, 2011 at 02:55:19PM -0400, Ted Ts'o wrote:
> On Fri, Jul 15, 2011 at 04:51:32PM +0200, Greg KH wrote:
> >
> > But none of them are on the Signed-off-by: line area, right?
>
> Is it really the case that your concern is that there be a whitespace
> between the bug tracker reference and the signed-off-by area? So
>
> Company-bug-id: ....
>
> Signed-off-by: ....
>
> is preferable to
>
> Company-bug-id:
> Signed-off-by: ...
>
> If that's your only concern, ok, whatever. I don't personally care a
> whole lot either way.
>
> It's not like there was ever any kind of formal standards committee
> that decided that adding "Acked-by" and "Tested-by" and "CC" were ok
> in the signed-off-by block, and other things weren't, after all.

But those were agreed apon, and standardized on, and look, documented,
as to how to use them.

If you want to propose, and document, using "Company-bug-id", that's
great, and is valid, but don't try to slip things in like this, with a
company specific name, into the standardized tag area and claim it is
acceptable after the fact.

Again, I think people here are somehow forgetting the 300+ different
companies that contribute to the kernel...

greg k-h