Re: [PATCH 1/2] Kconfig: Allow disabling of CONFIG_DEVPORT

Greg KH
2011-07-15T07:07:00Z

On Thu, Jul 14, 2011 at 03:17:24PM -0700, Mike Waychison wrote:
> On Thu, Jul 14, 2011 at 2:21 PM, Greg KH <gregkh@suse.de> wrote:
> > On Thu, Jul 14, 2011 at 01:34:52PM -0700, Mike Waychison wrote:
> >> It would be useful to build kernels with disabled support of /dev/port
> >> for systems where we do not want to allow an administrator to access IO
> >> ports directly.
> >>
> >> To do so however, CONFIG_DEVPORT needs to be user-selectable.  Give this
> >> configuration option a name and help description.
> >>
> >> Google-Bug-Id: 3177114
> >
> > What is that field?  It's not something that I've ever seen before...
>
> This is for our internal reference.

Internal reference to where?

> > Please don't push internal fields like this to public patches, it only
> > causes confusion...
>
> It hasn't caused any problems so far. It helps us track things as we
> pull code back downstream.

Ok, but what happens if all 2000+ different companies start adding their
fields to the signed-off-by: area of the kernel for their internal
tracking systems?

So please, don't do this, it makes no sense to the kernel community at
all and we really don't want to start adding more fields to this area if
we don't have to.

greg k-h