public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Vivek Goyal <vgoyal@redhat.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Americo Wang <xiyou.wangcong@gmail.com>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jarod Wilson <jwilson@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"dle-develop@lists.sourceforge.net" 
	<dle-develop@lists.sourceforge.net>,
	Satoru Moriya <satoru.moriya@hds.com>
Subject: Re: [RFC][PATCH] Replace a function call chain of kmsg_dump(KMSG_DUMP_KEXEC) with static function calls
Date: Sat, 16 Jul 2011 21:27:53 +0100	[thread overview]
Message-ID: <20110716202753.GA16161@srcf.ucam.org> (raw)
In-Reply-To: <m1hb6mgf3w.fsf@fess.ebiederm.org>

On Sat, Jul 16, 2011 at 01:11:47PM -0700, Eric W. Biederman wrote:

> Without some real understanding of what is going on I'm not inclined
> to meet any of this half way and summarily reject every change to
> the kexec on panic code path.

There are platforms that simply refuse to correctly function with a 1:1 
physical/virtual mapping. But that's not the point here - this patch 
simply hardcodes saving dmesg to an EFI variable rather than using 
kmsg_dump and pstore in order to avoid handling the locking, and does 
nothing whatsoever to change the amount of EFI code involved.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2011-07-16 20:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 15:47 [RFC][PATCH] Replace a function call chain of kmsg_dump(KMSG_DUMP_KEXEC) with static function calls Seiji Aguchi
2011-07-11 17:27 ` Matthew Garrett
2011-07-11 22:07 ` Vivek Goyal
2011-07-13  8:37 ` Américo Wang
2011-07-16 16:16 ` Eric W. Biederman
2011-07-16 16:28   ` Matthew Garrett
2011-07-16 20:11     ` Eric W. Biederman
2011-07-16 20:27       ` Matthew Garrett [this message]
2011-07-18 11:43   ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110716202753.GA16161@srcf.ucam.org \
    --to=mjg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dle-develop@lists.sourceforge.net \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=jwilson@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=satoru.moriya@hds.com \
    --cc=seiji.aguchi@hds.com \
    --cc=tony.luck@intel.com \
    --cc=vgoyal@redhat.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox