From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Greg KH <greg@kroah.com>, Grant Likely <grant@secretlab.ca>,
Jean Delvare <khali@linux-fr.org>,
Ben Dooks <ben-linux@fluff.org>,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>, Samuel Oritz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] regmap: Add generic non-memory mapped register access API
Date: Mon, 18 Jul 2011 19:50:54 +0900 [thread overview]
Message-ID: <20110718105053.GD7775@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hsjq3kh61.wl%tiwai@suse.de>
On Mon, Jul 18, 2011 at 12:38:14PM +0200, Takashi Iwai wrote:
> In most cases, val = map->work_buf + map->format.reg_bytes.
> How about a bit optimization?
> if (ret == -ENOTSUPP) {
Indeed, I'd had an additional optimization there in mind but it was to
do the checking before we try the gather write rather than after since
generally it'll be cheaper to do the pre-gathered write than the
gathered write (sometimes noticably cheaper as some controllers have an
appreciable overhead for starting transfers, especially at high data
rates).
I mostly didn't implement it yet because I was trying to minimize the
code complexity of the initial submission in order to aid review so was
avoiding non-essential features.
next prev parent reply other threads:[~2011-07-18 10:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 10:04 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-18 10:07 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-18 10:07 ` [PATCH 2/4] regmap: Add I2C bus support Mark Brown
2011-07-18 10:07 ` [PATCH 3/4] regmap: Add SPI " Mark Brown
2011-07-19 21:51 ` Grant Likely
2011-07-20 10:33 ` Mark Brown
2011-07-18 10:07 ` [PATCH 4/4] regulator: Convert tps65023 to use regmap API Mark Brown
2011-07-18 10:38 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Takashi Iwai
2011-07-18 10:50 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-16 2:48 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-16 2:48 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-15 6:22 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-15 6:23 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-09 4:49 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-09 4:50 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-09 5:44 ` Greg KH
2011-07-15 2:53 ` Grant Likely
2011-07-15 3:25 ` Mark Brown
2011-07-15 3:30 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718105053.GD7775@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ben-linux@fluff.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=grant@secretlab.ca \
--cc=greg@kroah.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox