From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756566Ab1GRLny (ORCPT ); Mon, 18 Jul 2011 07:43:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57645 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752538Ab1GRLny (ORCPT ); Mon, 18 Jul 2011 07:43:54 -0400 Date: Mon, 18 Jul 2011 07:43:34 -0400 From: Vivek Goyal To: "Eric W. Biederman" Cc: Seiji Aguchi , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , KOSAKI Motohiro , Americo Wang , Matthew Garrett , "tony.luck@intel.com" , Andrew Morton , Jarod Wilson , "hpa@zytor.com" , "dle-develop@lists.sourceforge.net" , Satoru Moriya Subject: Re: [RFC][PATCH] Replace a function call chain of kmsg_dump(KMSG_DUMP_KEXEC) with static function calls Message-ID: <20110718114334.GA31986@redhat.com> References: <5C4C569E8A4B9B42A84A977CF070A35B2C17AAE59A@USINDEVS01.corp.hds.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 16, 2011 at 09:16:06AM -0700, Eric W. Biederman wrote: [..] > Am I wrong in thinking that the core motivation behind this patch is > that our EFI support sucks and thus kdump on EFI does not work on some > platforms? One of the arguments seems is that kdump might not work 100% of the time and saving kernel messages atleast gets some information out reliably. I think being able to save dmesg to NVRAM, in general sounds good to me (if done in a relatively clean manner). Especially if we can get rid of code taking locks and code path executed after crash is not tool long and relatively easy to audit. Thanks Vivek