From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Tony Luck <tony.luck@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, mikew@google.com
Subject: Re: [PATCH 4/9] pstore: Allow the user to explicitly choose a backend
Date: Mon, 18 Jul 2011 22:00:51 +0100 [thread overview]
Message-ID: <20110718210051.GA815@srcf.ucam.org> (raw)
In-Reply-To: <CA+8MBbJMHK1e_wGC9EE+8neVc2j9Y8Ut4vzPiGh2umNZENsK1Q@mail.gmail.com>
On Mon, Jul 18, 2011 at 01:58:28PM -0700, Tony Luck wrote:
> On Mon, Jul 18, 2011 at 1:30 PM, Matthew Garrett <mjg@redhat.com> wrote:.
> > +
> > + Pstore only supports one backend at a time. If multiple
> > + backends are available, the preferred backend may be
> > + set by passing the pstore.backend= argument to the kernel
> > + or writing to /sys/module/pstore/parameters/backend .
> > \ No newline at end of file
>
> Maybe we should have a newline :-)
True...
> We don't allow backends to be unregistered (currently) - Do you think it would
> be helpful to mention in this text that you cannot change your mind and
> switch to a different back end once you have registered one? Writing
> to /sys/module/... sounds a lot more flexible than what reality will allow.
Mm. Yes, the lack of unregistration does make that less helpful. Perhaps
best to make that unwritable.
>
> > + if (backend && strcmp(backend, psi->name)) {
> > + spin_unlock(&pstore_lock);
> > + return -EBUSY;
> > + }
>
> EBUSY doesn't feel like the right error here (and we are using that
> to indicate that some other backend is already registered). Not
> sure what is the right one though. ENOENT? EINVAL?
EINVAL, I guess?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-07-18 21:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 20:30 Add an EFI pstore backend Matthew Garrett
2011-07-18 20:30 ` [PATCH 1/9] pstore: Extend API Matthew Garrett
2011-07-18 20:30 ` [PATCH 2/9] pstore: Add extra context for writes and erases Matthew Garrett
2011-07-18 20:30 ` [PATCH 3/9] pstore: Make "part" unsigned Matthew Garrett
2011-07-18 20:30 ` [PATCH 4/9] pstore: Allow the user to explicitly choose a backend Matthew Garrett
2011-07-18 20:58 ` Tony Luck
2011-07-18 21:00 ` Matthew Garrett [this message]
2011-07-18 21:08 ` Tony Luck
2011-07-20 13:27 ` Konrad Rzeszutek Wilk
2011-07-20 14:29 ` Luck, Tony
2011-07-18 20:30 ` [PATCH 5/9] efi: Add support for using efivars as a pstore backend Matthew Garrett
2011-07-18 20:30 ` [PATCH 6/9] efivars: String functions Matthew Garrett
2011-07-18 20:30 ` [PATCH 7/9] efivars: introduce utf16_strncmp Matthew Garrett
2011-07-18 20:30 ` [PATCH 8/9] efivars: Use string functions in pstore_write Matthew Garrett
2011-07-18 20:30 ` [PATCH 9/9] efivars: Introduce PSTORE_EFI_ATTRIBUTES Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718210051.GA815@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox