[PATCH/RFC 4/5] usb:dummy_hcd: Disable single-request fifo in dummy hcd

Tatyana Brokhman
2011-06-16T13:32:12Z

This is not the actual behavior of the udc, thus it's removed.

This patch is needed for several of UAS test to pass.

Signed-off-by: Tatyana Brokhman <tlinder@codeaurora.org>

---
drivers/usb/gadget/dummy_hcd.c | 26 +-------------------------
1 files changed, 1 insertions(+), 25 deletions(-)

diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index 7d0a6fe..41c7961 100644
--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -608,11 +608,6 @@ dummy_free_request (struct usb_ep *_ep, struct usb_request *_req)
kfree (req);
}

-static void
-fifo_complete (struct usb_ep *ep, struct usb_request *req)
-{
-}
-
static int
dummy_queue (struct usb_ep *_ep, struct usb_request *_req,
gfp_t mem_flags)
@@ -648,26 +643,7 @@ dummy_queue (struct usb_ep *_ep, struct usb_request *_req,
_req->actual = 0;
spin_lock_irqsave (&dum->lock, flags);

- /* implement an emulated single-request FIFO */
- if (ep->desc && (ep->desc->bEndpointAddress & USB_DIR_IN) &&
- list_empty (&dum->fifo_req.queue) &&
- list_empty (&ep->queue) &&
- _req->length <= FIFO_SIZE) {
- req = &dum->fifo_req;
- req->req = *_req;
- req->req.buf = dum->fifo_buf;
- memcpy (dum->fifo_buf, _req->buf, _req->length);
- req->req.context = dum;
- req->req.complete = fifo_complete;
-
- list_add_tail(&req->queue, &ep->queue);
- spin_unlock (&dum->lock);
- _req->actual = _req->length;
- _req->status = 0;
- _req->complete (_ep, _req);
- spin_lock (&dum->lock);
- } else
- list_add_tail(&req->queue, &ep->queue);
+ list_add_tail(&req->queue, &ep->queue);
spin_unlock_irqrestore (&dum->lock, flags);

/* real hardware would likely enable transfers here, in case
--
1.7.3.3

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.