From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751144Ab1GSNX6 (ORCPT ); Tue, 19 Jul 2011 09:23:58 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:18673 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952Ab1GSNX4 (ORCPT ); Tue, 19 Jul 2011 09:23:56 -0400 Date: Tue, 19 Jul 2011 09:21:49 -0400 From: Konrad Rzeszutek Wilk To: Joe Jin Cc: Ian Campbell , Jeremy Fitzhardinge , Kurt C Hackel , Greg Marsden , "linux-kernel@vger.kernel.org" , "annie.li@oracle.com" , "xen-devel@lists.xensource.com" , Jens Axboe , "stable@kernel.org" , Daniel Stodden Subject: Re: [Xen-devel] Re: [PATCH resubmit] xen-blkfront: Don't send closing notification to backend in blkfront_closing() Message-ID: <20110719132149.GA3178@dumpdata.com> References: <4E1CEB34.5090907@oracle.com> <1310631209.634.444.camel@zakaz.uk.xensource.com> <4E1EAEE9.80605@oracle.com> <1310634779.634.480.camel@zakaz.uk.xensource.com> <4E1FF33A.8090101@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E1FF33A.8090101@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4E2584F8.0117:SCFMA922111,ss=1,re=-4.000,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2011 at 03:58:50PM +0800, Joe Jin wrote: > On 07/14/11 17:12, Ian Campbell wrote: > > On Thu, 2011-07-14 at 09:55 +0100, Joe Jin wrote: > >> On 07/14/11 16:13, Ian Campbell wrote: > >>> On Wed, 2011-07-13 at 01:47 +0100, Joe Jin wrote: > > > >>> > >>> I'm wondering if we might not be better off deferring the disconnect on > >>> the backend side until the frontend enters XenbusStateClosed instead of > >>> doing it in closing. > >> > >> Yes this fix from backend side works too, also this looks reasonable than > >> fix in frontend. > > > > I guess there is either a missing "more" or "less" in that sentence ;-) > > > > The nice thing about a backend fix is that you don't need to go round > > propagating the fix into distros etc and updating existing deployed > > guests (not to mention non-Linux frontends). > > Indeed ;) > > > > > I actually thought blkback had something like this already in older > > "classic" Xen kernels but it seems like the patch never made it out of > > the XCP patch queue :-(. See > > http://xenbits.xen.org/hg/XCP/linux-2.6.32.pq.hg/file/tip/CA-7672-blkback-shutdown.patch > > (which appears to also incorporate a toolstack directed graceful > > shutdown of some sort as well as deferring the device close). > > > > Daniel, do you know of any plans to extricate that stuff from the XCP > > patch queue for upstream? Are there any other patches (e.g. incremental > > fixes) in that pq which should go along with it? > > Looking forward push this patch to upstream! Not sure if Daniel is going to get to this. Joe, and chance you could take a look at it and up-port in the 3.0 kernel?