From: Don Zickus <dzickus@redhat.com>
To: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: Matthew Garrett <mjg@redhat.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Vivek Goyal <vgoyal@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Americo Wang <xiyou.wangcong@gmail.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jarod Wilson <jwilson@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"dle-develop@lists.sourceforge.net"
<dle-develop@lists.sourceforge.net>,
Satoru Moriya <satoru.moriya@hds.com>
Subject: Re: [RFC][PATCH -mmotm 1/4] Add static function calls of pstore to kexec path
Date: Tue, 19 Jul 2011 14:54:11 -0400 [thread overview]
Message-ID: <20110719185411.GA3400@redhat.com> (raw)
In-Reply-To: <5C4C569E8A4B9B42A84A977CF070A35B2C199C64D6@USINDEVS01.corp.hds.com>
On Tue, Jul 19, 2011 at 02:48:22PM -0400, Seiji Aguchi wrote:
> >How is this safe? What happens if there's a pstore access in process
> >when you hit this codepath?
>
> This will never happen because pstore_kmsg_dump_in_interrupt() is called after machine_crash_shutdown().
>
> Panicked cpu sends NMI to all other cpus in machine_crash_shutdown() and they stop.
>
>
> @@ -1081,6 +1083,7 @@ void crash_kexec(struct pt_regs *regs)
> crash_setup_regs(&fixed_regs, regs);
> crash_save_vmcoreinfo();
> machine_crash_shutdown(&fixed_regs);
> + pstore_kmsg_dump_in_interrupt(KMSG_DUMP_KEXEC);
>
> Seiji
Another interesting question is do we need to log anything in the kdump
path? Isn't kdump generating the same info? What added value do we get
over kdump?
Cheers,
Don
next prev parent reply other threads:[~2011-07-19 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 18:24 [RFC][PATCH -mmotm 1/4] Add static function calls of pstore to kexec path Seiji Aguchi
2011-07-19 18:35 ` Matthew Garrett
2011-07-19 18:48 ` Seiji Aguchi
2011-07-19 18:52 ` Matthew Garrett
2011-07-19 19:14 ` Seiji Aguchi
2011-07-19 19:27 ` Matthew Garrett
2011-07-19 19:40 ` Matthew Garrett
2011-07-19 18:54 ` Don Zickus [this message]
2011-07-19 19:02 ` Vivek Goyal
2011-07-19 19:20 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719185411.GA3400@redhat.com \
--to=dzickus@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dle-develop@lists.sourceforge.net \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=jwilson@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mjg@redhat.com \
--cc=satoru.moriya@hds.com \
--cc=seiji.aguchi@hds.com \
--cc=tony.luck@intel.com \
--cc=vgoyal@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox