Re: [PATCH] vfs: fix race in rcu lookup of pruned dentry

Al Viro
2011-07-18T23:40:17Z

On Mon, Jul 18, 2011 at 04:27:53PM -0700, Linus Torvalds wrote:
> On Mon, Jul 18, 2011 at 4:21 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Linus, are you OK with me slapping your s-o-b on it?
>
> Yup.
>
> And it feels so right that I think we should just do it for 3.0.
>
> I was planning on doing that today, but I guess can delay it too. I'm
> at the Intel tech days tomorrow and the day after, but there's WiFi
> there and I'll have my laptop. The slightly bigger problem is that it
> will move the next merge window even further into my upcoming
> vacation, but I was planning on having the laptop with me there too,
> so whatever...
>
> I assume I'll get the cifs_get_root() fix at the same time.

Yes. Maybe btrfs get_default_root() one as well, if it survives beating;
also a missing i_mutex, along with seriously wrong use of d_splice_alias()
(it ignores the return value, for starters, and assumes that inode will
not be found in icache once all dentries pointing to it are off the alias
list)