Re: [PATCH 3/4] regmap: Add SPI bus support

Grant Likely
2011-07-19T21:51:26Z

On Mon, Jul 18, 2011 at 07:07:42PM +0900, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Acked-by: Liam Girdwood <lrg@ti.com>
> Acked-by: Wolfram Sang <w.sang@pengutronix.de>

One comment below, but otherwise:

Acked-by: Grant Likely <grant.likely@secretlab.ca>

on the whole series.
> diff --git a/include/linux/regmap.h b/include/linux/regmap.h
> index e509bac..c549632 100644
> --- a/include/linux/regmap.h
> +++ b/include/linux/regmap.h
> @@ -61,6 +61,9 @@ struct regmap *regmap_init(struct device *dev,
> const struct regmap_config *config);
> struct regmap *regmap_init_i2c(struct device *dev,
> const struct regmap_config *config);
> +struct regmap *regmap_init_spi(struct device *dev,
> + const struct regmap_config *config);
> +

regmap_init_i2c/spi should take an i2c_client and spi_device pointer
respectively so it can be type checked.

> void regmap_exit(struct regmap *map);
> int regmap_write(struct regmap *map, unsigned int reg, unsigned int val);
> int regmap_raw_write(struct regmap *map, unsigned int reg,
> --
> 1.7.5.4
>