Re: RFC: Boiler plate functions for ida / idr allocation?

[Tejun Heo <tj@kernel.org>]

On Thu, Jul 21, 2011 at 10:19:46AM +0200, Tejun Heo wrote:
> On Thu, Jul 21, 2011 at 05:07:36PM +0930, Rusty Russell wrote:
> > From: Rusty Russell <rusty@rustcorp.com.au>
> > Subject: ida: Simplified functions for id allocation.
> > 
> > The current hyper-optimized functions are overkill if you simply want
> > to allocate an id for a device.  Create versions which use an internal
> > lock.
> > 
> > Thanks to Tejun for feedback.  Feel free to delete the #ifdef TEST
> > code.
> > 
> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ...
> >  static struct kmem_cache *idr_layer_cache;
> > +static DEFINE_SPINLOCK(simple_ida);
> 
> I think the name is a bit confusing.  Maybe simple_ida_lock is better?
> Other than that,

Ooh, one more thing, maybe it would be better to use spin_lock_irq()
to allow calling free under other irq locks.

Thanks.

-- 
tejun