public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Matt Mackall <mpm@selenic.com>, NeilBrown <neilb@suse.de>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Nanosecond fs timestamp support: sad
Date: Fri, 22 Jul 2011 18:31:58 -0400	[thread overview]
Message-ID: <20110722223158.GC10749@fieldses.org> (raw)
In-Reply-To: <20110722221039.GB10749@fieldses.org>

On Fri, Jul 22, 2011 at 06:10:39PM -0400, bfields wrote:
> On Fri, Jul 22, 2011 at 11:47:32PM +0200, Andi Kleen wrote:
> > On Fri, Jul 22, 2011 at 04:11:42PM -0500, Matt Mackall wrote:
> > > On Fri, 2011-07-22 at 22:59 +0200, Andi Kleen wrote:
> > > > > Indeed. Only usefully exists on ext4 and requires extra system calls.
> > > > 
> > > > Not sure what you mean?  It's in stat(2), just like the timestamps.
> > > 
> > > I don't see anything that looks like a version or generation number in
> > > either the man pages, the asm-generic/stat.h, or glibc's asm/stat.h.
> > > Pointer?
> > 
> > Hmm you're right. I thought it was in there, but apparently not.
> > I think it should be added there though. We still have some unused 
> > fields.
> 
> But last I checked I thought it was only ext4 that actually incremented
> the i_version on IO, and even then only when given a (non-default) mount
> option.
> 
> My notes on what needs to be done there:
> 
> 	- collect data to determine whether turning on i_version causes
> 	  any significant performance regressions.
> 		- Last I talked to him, Ted Tso recommended running
> 		  Bonnie on a local disk, since it does a lot of little
> 		  writes, which is somewhat of a worst case, as it will
> 		  generate extra metadata updates for each write.
> 		  Compare total wall-clock time, number of iops, and
> 		  number of bytes (using some kind of block tracing).
> 	- If there aren't any problems, turn it on by default, and we're
> 	  done.

(Well,and talk the other filesystem implementors into doing it.)

--b.

>	  If there are unfixable problems, consider something
> 	  more complicated (like turning on i_version automatically when
> 	  someone asks for it).
> 	- We need to check that i_version is also doing something
> 	  sensible on directory as well as on file inodes.
> 	- We also need to think about what it does after reboots.  (E.g.
> 	  what is an nfs server to do if clients see the i_version go
> 	  backwards (and hence possible repeat old values) after a
> 	  reboot?)
> 	- Double-check the order that data updates and i_version updates
> 	  are done in.  (Ideal would be if they were atomic, but for
> 	  nfsd's purposes at least it should be adequate if the
> 	  i_version comes after, and no later than the next commit.)
> 
> --b.

  reply	other threads:[~2011-07-22 22:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-21 18:07 Nanosecond fs timestamp support: sad Matt Mackall
2011-07-22  6:01 ` Andi Kleen
2011-07-22  6:33   ` NeilBrown
2011-07-22 19:34     ` Matt Mackall
2011-07-22 20:59       ` Andi Kleen
2011-07-22 21:11         ` Matt Mackall
2011-07-22 21:47           ` Andi Kleen
2011-07-22 22:10             ` J. Bruce Fields
2011-07-22 22:31               ` J. Bruce Fields [this message]
2011-07-22 22:59                 ` NeilBrown
2011-07-22 23:06                   ` J. Bruce Fields
2011-07-22 23:49                     ` J. Bruce Fields
2011-07-23  0:07                       ` NeilBrown
2011-07-23  0:07                   ` Matt Mackall
2011-07-23  1:38                     ` J. Bruce Fields
2011-07-23  2:10                       ` Trond Myklebust
2011-07-24  1:56                       ` Andi Kleen
2011-07-29 19:49                     ` Pavel Machek
2011-07-29 21:37                       ` Matt Mackall
2011-07-23  1:13                   ` Andreas Dilger
2011-07-25 15:09                   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110722223158.GC10749@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=andi@firstfloor.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox