From: Willy Tarreau <w@1wt.eu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ben Greear <greearb@candelatech.com>, Ingo Molnar <mingo@elte.hu>,
John Stultz <john.stultz@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
stable@kernel.org
Subject: Re: [stable] [patch 3/3] rtc: Limit frequency
Date: Sat, 23 Jul 2011 00:39:15 +0200 [thread overview]
Message-ID: <20110722223915.GA22405@1wt.eu> (raw)
In-Reply-To: <20110722150550.1878f069.akpm@linux-foundation.org>
On Fri, Jul 22, 2011 at 03:05:50PM -0700, Andrew Morton wrote:
> On Fri, 22 Jul 2011 09:12:51 -0000
> Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > The RTC hrtimer is self rearming. We really need to limit the
> > frequency to something sensible.
>
> > Cc: stable@kernel.org
>
> Why? What failures does the current code cause? What effect do these
> failures have upon users?
I would add that if we go that route, we should at least accept values
that were documented as possible till now. Man rtc says 2 Hz to 8192 Hz,
but Thomas' proposed patch limits it to 5000 Hz, so some breakage is to
be expected.
Regards,
Willy
next prev parent reply other threads:[~2011-07-22 22:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 9:12 [patch 0/3] rtc: Assorted bug fixes Thomas Gleixner
2011-07-22 9:12 ` [patch 1/3] rtc: Handle errors correctly in rtc_irq_set_state() Thomas Gleixner
2011-07-22 22:04 ` Andrew Morton
2011-07-23 7:15 ` Thomas Gleixner
2011-07-22 9:12 ` [patch 2/3] rtc: Fix hrtimer deadlock Thomas Gleixner
2011-07-22 22:11 ` Andrew Morton
2011-07-23 7:22 ` Thomas Gleixner
2011-07-22 9:12 ` [patch 3/3] rtc: Limit frequency Thomas Gleixner
2011-07-22 22:05 ` Andrew Morton
2011-07-22 22:39 ` Willy Tarreau [this message]
2011-08-05 3:39 ` [stable] " Joshua Kinard
2011-08-05 9:04 ` John Stultz
2011-08-06 7:28 ` Joshua Kinard
2011-07-23 7:17 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722223915.GA22405@1wt.eu \
--to=w@1wt.eu \
--cc=akpm@linux-foundation.org \
--cc=greearb@candelatech.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox