From: Matthew Garrett <mjg@redhat.com>
To: Andrew Lutomirski <luto@mit.edu>
Cc: cpufreq@vger.kernel.org, davej@redhat.com,
linux-kernel@vger.kernel.org, borislav.petkov@amd.com,
mark.langsdorf@amd.com, andreas.herrmann3@amd.com
Subject: Re: [PATCH v4 3/7] acpi-cpufreq: Add support for disabling dynamic overclocking
Date: Sun, 24 Jul 2011 04:49:37 +0100 [thread overview]
Message-ID: <20110724034937.GA25873@srcf.ucam.org> (raw)
In-Reply-To: <CAObL_7Gis4YaSB+suFXxLmSchmJaEc6Jqv6aY6VvWynuEkRb5A@mail.gmail.com>
On Sat, Jul 23, 2011 at 11:42:50PM -0400, Andrew Lutomirski wrote:
> On Sat, Jul 23, 2011 at 11:33 PM, Matthew Garrett <mjg@redhat.com> wrote:
> > This complicates things a little, since right now we just write the
> > firmware's P state value directly into PERF_CTL. We'd need to add code
> > to acpi_cpufreq_target to make sure that it masked that bit off. It's a
> > little more awkward, but if we're being told not to do it by just
> > hitting the bit in MISC_ENABLE it's probably worth it. I'll try to
> > handle that this week.
>
> This way may give the benefit of making it work per core instead of
> per package. The manual is rather unclear on this point.
Being able to enter turbo mode typically requires coordination between
the cores in order to ensure that the package remains within limits. The
AMD implementation certainly disables their equivalent entirely if any
core in the package has it disabled. I haven't verified that Intel
behaviour is identical, but it wouldn't surprise me. I can try to check
that.
> I actually have a use case for this. I have a system that keeps a
> bunch of cores under moderate load. I have one thread in particular
> that needs to be fast, and I'd like to disable boosting on the other
> cores to keep more thermal and power headroom available for the one
> thread that cares.
Are the other threads sufficiently opportunistic to use extra CPU power
if it's available to them? You'll generally only get turbo if the other
cores are in C6, so even if turbo is disabled on a specific core it'll
probably prevent another core from entering turbo if anything's
executing on it. You'd arguably want it to be able to get into turbo so
it can hit C6 more quickly and let the other thread use the extra
headroom.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-07-24 3:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 16:37 [PATCH v4] Move modern AMD cpufreq support to acpi-cpufreq Matthew Garrett
2011-07-18 16:37 ` [PATCH v4 1/7] x86: Add AMD HW_PSTATE cpu feature bit and MSRs Matthew Garrett
2011-07-18 16:37 ` [PATCH v4 2/7] acpi-cpufreq: Add support for modern AMD CPUs Matthew Garrett
2011-07-18 16:37 ` [PATCH v4 3/7] acpi-cpufreq: Add support for disabling dynamic overclocking Matthew Garrett
2011-07-22 14:41 ` Borislav Petkov
2011-07-22 14:49 ` Matthew Garrett
2011-07-24 3:06 ` Andy Lutomirski
2011-07-24 3:28 ` Matthew Garrett
2011-07-24 3:15 ` Andy Lutomirski
2011-07-24 3:33 ` Matthew Garrett
2011-07-24 3:42 ` Andrew Lutomirski
2011-07-24 3:49 ` Matthew Garrett [this message]
2011-07-24 9:36 ` Borislav Petkov
2011-07-18 16:37 ` [PATCH v4 4/7] ACPI: Add fixups for AMD P-state figures Matthew Garrett
2011-07-18 16:37 ` [PATCH v4 5/7] cpufreq: Add compatibility hack to powernow-k8 Matthew Garrett
2011-07-18 16:37 ` [PATCH v4 6/7] cpufreq: Remove support for hardware P-state chips from powernow-k8 Matthew Garrett
2011-07-22 14:43 ` Borislav Petkov
2011-07-18 16:37 ` [PATCH v4 7/7] cpufreq: Add boost alias to cpb Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110724034937.GA25873@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=andreas.herrmann3@amd.com \
--cc=borislav.petkov@amd.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=mark.langsdorf@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox